[Feature]: Gas Optimization & Fee Analysis#130
Merged
SudiptaPaul-31 merged 1 commit intoJun 24, 2026
Merged
Conversation
- Replace bulk Vec<Milestone> storage with individual milestone keys for O(1) lookups - Inline client/freelancer approval flags into Milestone struct, removing 2 extra storage entries per milestone - Remove duplicate MilestoneDeadline storage key (deadline already in Milestone struct) - Add event emission for all lifecycle events (init, fund, submit, approve, confirm, release, refund, dispute, resolve, expire) - Maintain full backward compatibility for all getter functions Closes Lumina-eX#84
|
@samsonmbah002 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Problem Statement
Measure and analyze the gas costs of contract execution. Optimize storage usage and reduce transaction footprint to improve efficiency and minimize fees.
✅ Changes Made
Escrow Contract Optimizations:
Vec<Milestone>storage with individualDataKey::Milestone(u32)keys, enabling O(1) lookups instead of O(n) iteration for single-milestone operationsclient_approvedandfreelancer_approvedinto theMilestonestruct, eliminating 2 separate storage entries per milestoneMilestoneDeadline(u32)key since deadline is already in the Milestone struct📈 Impact
Closes #84