Repository navigation
Conversation
With no microphone connected (Mac mini, Mac Studio), the input node's hardware format reports 0 ch / 0 Hz and installTap raises an uncatchable NSException during app launch. The node's outputFormat still reports a synthetic 2 ch / 44.1 kHz format, so it cannot be used to detect the missing device. Check inputFormat(forBus:) before installing the tap and bail out with a catchable error so the caller can show the unavailable state. Patch by [gabbe](https://github.com/gabbe-swe) with [Devin](https://devin.ai)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #949
With no microphone connected (Mac mini, Mac Studio), the input node's hardware format reports 0 ch / 0 Hz and installTap raises an uncatchable NSException during app launch. The node's outputFormat still reports a synthetic 2 ch / 44.1 kHz format, so it cannot be used to detect the missing device.
Check inputFormat(forBus:) before installing the tap and bail out with a catchable error so the caller can show the unavailable state.
Patch by gabbe with Devin
Verified
On a Mac mini M4 (macOS 26.6.2) with no input device and
voiceEnabled = 1:SIGABRTon every launch,VoiceAudio.start()→installTapOnBusin the crash trace.
[Voice] no audio input device — pipeline skipped; voice features show theunavailable state and recover when a mic is connected
(
AVAudioEngineConfigurationChangehandling is already in place).Follow-ups (not in this patch)
(
MacDictation.swift,NoteAudio.swift,ParakeetEngine.swift) if they canrun with no input device.
SettingsView.init(),so an audio failure can never block launch.