Repository navigation
fix(arch): install the desktop entry under the portal's app id - #945
Closed
rahul05ranjan wants to merge 2 commits into
Closed
rahul05ranjan wants to merge 2 commits into
rahul05ranjan wants to merge 2 commits into
Conversation
Install and uninstall removed a whole Claude Code hook group when any command in it mentioned coucou or NotchBuddy, so a user hook like ~/dev/coucou/scripts/lint.sh was deleted. Both paths now use the Gemini path's removeNbHookEntries, which removes only nb-hook commands and drops a group only when every entry in it was ours. Fixes Louis-CFM#854 Co-authored-by: rahul05ranjan <11793455+rahul05ranjan@users.noreply.github.com>
The GlobalShortcuts portal resolves app info through <app-id>.desktop, and the Tauri identifier Coucou reports is fr.louisraille.coucou (windows/src-tauri/src/portal.rs). The PKGBUILD installed the entry as coucou.desktop, so the portal could not register the app id and global shortcuts failed on Arch installs. Fixes Louis-CFM#804 Co-authored-by: rahul05ranjan <11793455+rahul05ranjan@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #804.
What was wrong
The Arch PKGBUILD installs the desktop entry as
/usr/share/applications/coucou.desktop, but Coucou tells the GlobalShortcuts portal its Tauri identifier,fr.louisraille.coucou(windows/src-tauri/src/portal.rs:45):The portal resolves app info for an id through
<app-id>.desktopunder/usr/share/applications, so it looks forfr.louisraille.coucou.desktop, does not find it, and the session is rejected:The fix
One line in
linux/arch/PKGBUILD: install the entry under the identifier the app reports:The file's contents are unchanged, so menus and launchers keep working as before (
Name=Coucou,Icon=coucou,Exec=coucou); only the lookup name the portal needs changes.Verification
I could not run makepkg or a desktop portal on this machine (no Arch here), so:
windows/src-tauri/src/portal.rsonmain: the app id passed to the portal session is exactlyfr.louisraille.coucou(line 45, used at line 374 to name the session). The installed file name onmainis exactlycoucou.desktop, so the mismatch is real on HEAD.linux/arch/coucou.desktopwith Python'sconfigparserafter the change: still a valid Desktop Entry (Type=Application,Exec=coucou,Icon=coucou) — the change is to the install destination only.fr.louisraille.coucou.desktopmakes the portal resolve the app id and the log switch toshortcuts: registered with the desktop portal.