Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ jobs:
- name: Test auto-close timing
run: bash scripts/test-auto-close.sh

- name: Test Mac translations (Traditional Chinese coverage, format arguments, catalog keys)
run: python3 scripts/test-localization.py

- name: Test open on hover
run: bash scripts/test-island-hover.sh

Expand Down
10 changes: 10 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@ Check auto-close timing and live setting changes:
bash scripts/test-auto-close.sh
```

Check macOS translations:

```bash
python3 scripts/test-localization.py
```

Add English and Traditional Chinese entries for every new localized label. Keep
format arguments and plural paths intact. This check does not replace building
both Mac targets or checking the language and layout in the app.

## Good first contributions

- A new service integration (a poller + an entry in `PillCatalog.swift` in the `.service` category + a detail card). Look at `StripePoller.swift` for a compact example.
Expand Down
4 changes: 4 additions & 0 deletions NotchBuddy/Resources/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,17 @@
<string>en</string>
<string>ar</string>
<string>bn</string>
<string>de</string>
<string>es</string>
<string>fr</string>
<string>hi</string>
<string>id</string>
<string>pt-BR</string>
<string>ru</string>
<string>th</string>
<string>tr</string>
<string>zh-Hans</string>
<string>zh-Hant</string>
</array>
<key>CFBundleName</key>
<string>Coucou</string>
Expand Down
4 changes: 4 additions & 0 deletions NotchBuddy/Resources/InfoAppStore.plist
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,17 @@
<string>en</string>
<string>ar</string>
<string>bn</string>
<string>de</string>
<string>es</string>
<string>fr</string>
<string>hi</string>
<string>id</string>
<string>pt-BR</string>
<string>ru</string>
<string>th</string>
<string>tr</string>
<string>zh-Hans</string>
<string>zh-Hant</string>
</array>
<key>CFBundleName</key>
<string>Coucou</string>
Expand Down
Loading
Loading