Repository navigation
Add Traditional Chinese localization to macOS - #314
Closed
shawn-t516 wants to merge 14 commits into
Closed
shawn-t516 wants to merge 14 commits into
shawn-t516 wants to merge 14 commits into
Conversation
Merge upstream c946650 while preserving existing locales and macOS Traditional Chinese. Translate new Spotify and dictation labels and regenerate the Xcode project.
shawn-t516
marked this pull request as ready for review
October 9, 2026 02:04
Merge upstream 0dffbaf while preserving existing locales and macOS behavior. Add Traditional Chinese for new Voice, Mail, and Crypto labels and make source-key validation handle Swift Unicode literals.
Merge current upstream and retain existing translations. Translate new Portfolio and provider settings, and check static UI labels.
shawn-t516
changed the title
Merge upstream and add the 20 new Traditional Chinese strings while preserving all prior translations and other locales.
Merge upstream and preserve the catalog by key, adding 23 Traditional Chinese translations without losing prior locales. Reject duplicate catalog keys in the existing localization check.
Preserve the upstream WhatsApp pill and localize its Integration subtitle. Add 69 Traditional Chinese entries while retaining all 791 earlier translations and upstream locale metadata.
shawn-t516
changed the title
Louis-CFM
pushed a commit
that referenced
this pull request
Oct 20, 2026
shawn-t516's Traditional Chinese translation: - Localizable.xcstrings: the "zh-Hant" localization of every key, from #314 (plus the update.* and step.needs-input strings main gained since), and 繁體中文 in the language picker after 简体中文; CFBundleLocalizations of both Mac targets. - #314's wrapping of hard-coded English in String(localized:): outfit names (MochiWardrobe), PillCatalog category titles and subtitles, and the DeepSeek, Qwen and Moonshot "key saved" messages. Pill ids are unchanged. The catalog gains #314's new keys (those, plus literals the code already shows that the catalog lacked, and the plan card's Change plan, Auto mode and Manual buttons), each translated in every language; the ones Windows already translates in extra.json reuse those translations (and #701/#700's German and Turkish) and leave extra.json, since the Mac catalog now has them. Brand names and URLs keep their English text. - scripts/test-localization.py and its CONTRIBUTING note, now also run by the macOS Build workflow. Co-Authored-By: shawn-t516 <180199675+shawn-t516@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LJm3SRL9k3gBPaVtfPhwcT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Superseded by upstream: the maintainer incorporated Traditional Chinese from this PR in a8dcdfc, released through #821 and Mac 0.5.2. All original 860 catalog keys and Traditional Chinese values are retained exactly, together with the language picker, localization declarations, localized catalog/wardrobe labels and validation script. Upstream now has 904 translated entries.
On 2026-10-21, reconciled this branch with upstream
1e5180921c1326fc72e41d313e3e2855e9c10162. Head1bbc22f1c61219ca1f1092e5b01e869158ce70a1has exactly the same full tree as upstream; there is no remaining implementation diff to merge. Closing this redundant PR avoids duplicating already accepted work. The remaining Codex integration continues in #315.Verification
From repository root with Python 3, Xcode 27 and XcodeGen:
Passed: 904 unique fully translated entries, placeholder/plural paths, localized literal coverage, both macOS language declarations, wardrobe and pill colors; actual Xcode resource compilation matches 903 plain values and 1 plural entry. Entire branch tree equals the pinned upstream. Both merge orders with #315 yield #315's tested tree.
Not run: independent manual language/layout review. GitHub workflow approval is separate from local validation. No new CI or Windows build work was added.
Scope and authorship
Leaf localization change. All task-authored changes used OpenAI Codex; generated project/Info output used XcodeGen. Upstream imported work retains its original history/authors. The requester confirmed no other AI tool use and no human line-by-line source review. Automated checks are not human linguistic acceptance.