Repository navigation
fix(server): deleting an old pre-v2 fork thread removes its folder and workspace file - #351
Merged
Conversation
…d workspace file The pre-v2 multi-repo fork wrote its workspace file as a real file inside the run's container. remove() keeps real files, so deleting a migrated thread left the container, the beside .code-workspace and the layout file behind. A run with no root repository whose only leftover is that one .code-workspace file is now removed in full; any other leftover still keeps the folder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LoganRupe
approved these changes
Oct 15, 2026
LoganRupe
left a comment
LoganRupe
left a comment
Owner
There was a problem hiding this comment.
Thanks, this is tidy. Folding the fork case into remove() after removeLeftovers keeps the normal path untouched, and the notes.md test covers the case I'd have asked about.
stefanvandervelden-zipline
deleted the
fix/multi-repo/fork-thread-delete-cleanup
branch
October 15, 2026 05:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the follow-up to #350. Deleting a thread migrated from the pre-v2 multi-repo fork left three things behind: its container folder,
<container>.code-workspacebeside it, and the layout file. The fork wrote its workspace file as a real file inside the container.remove()keeps real files, so the container survived, and the beside files are only deleted once the container is gone.remove()now handles that case. For a run with no root repository, if the container's only content after the usual cleanup is one real.code-workspacefile, the container is deleted along with it, and the beside files are then cleaned up as usual. Any other leftover file still keeps the folder, as before.There are two new tests in
WorkspaceWorktrees.test.ts. A fork-shaped run gets fully removed, and a fork run that also holds anotes.mdkeeps both files. The first test fails without the fix.Written with Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code