Repository navigation
fix(server): keep long multi-repo setup terminal ids distinct - #329
Merged
LoganRupe merged 1 commit intoSep 30, 2026
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation correctly addresses the collision and includes appropriate regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Prevents collisions between long multi-repo setup terminal IDs while preserving existing IDs within the limit.
Changes:
- Adds deterministic hash suffixes when generated IDs exceed 128 characters.
- Verifies per-repo terminal IDs and
T3CODE_REPO_ROOTpropagation.
| File | Description |
|---|---|
apps/server/src/project/ProjectSetupScriptRunner.ts |
Generates bounded, collision-resistant setup terminal IDs. |
apps/server/src/project/ProjectSetupScriptRunner.test.ts |
Covers multi-repo environment propagation and long-ID distinction. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Follow-up to #328, from Copilot's review there.
T3CODE_REPO_ROOTand the per-repo terminal id reachterminalManager.open. feat(server): run the setup script in every repo of a multi-repo worktree #328's server test mocked the runner, so it never covered this.Why
The collision takes a very long script id or repo name, but when it happens a setup script is killed with no message. The env test closes the coverage gap Copilot pointed out.