Repository navigation
fix: center branch icons in session menu - #1746
Merged
Merged
Conversation
Model: gpt-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Problem / pressure
The branch row in a session's More actions menu overrides the menu's vertical alignment with
items-start. Its branch and copy icons sit above the center of the row.Summary
Remove that override so the row uses
Menu.Item's default centered alignment.Visual explanation
Before / after
Same Storybook menu, viewport, theme and interaction state; left is before, right is after.
Test plan
pnpm formatand the changed file's Oxfmt check passed.pnpm run docs checkpassed.pnpm check: typechecks, lint, Effect lint and script tests passed. The CLI testroost-session-backend-contract.test.tstimed out in “rejects an edit for an older active goal and rebuilds an invalid derived cache” (30 seconds); the remaining recursive test run was stopped after that failure.