Skip to content

fix: center branch icons in session menu - #1746

Merged
Lampese merged 1 commit into
mainfrom
codex/center-session-menu-icons
Oct 19, 2026
Merged

Lampese merged 1 commit into
mainfrom
codex/center-session-menu-icons

Conversation

@Lampese

@Lampese Lampese commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Related issue

Problem / pressure

The branch row in a session's More actions menu overrides the menu's vertical alignment with items-start. Its branch and copy icons sit above the center of the row.

Summary

Remove that override so the row uses Menu.Item's default centered alignment.

Visual explanation

- <Menu.Item className="items-start" ...>
+ <Menu.Item ...>  // uses the menu's align-items: center

Before / after

Before and after: branch and copy icons vertically centered

Same Storybook menu, viewport, theme and interaction state; left is before, right is after.

Test plan

  • Visually compared the same SessionTabBar Storybook menu at the same viewport size before and after the change.
  • pnpm format and the changed file's Oxfmt check passed.
  • pnpm run docs check passed.
  • pnpm check: typechecks, lint, Effect lint and script tests passed. The CLI test roost-session-backend-contract.test.ts timed out in “rejects an edit for an older active goal and rebuilds an invalid derived cache” (30 seconds); the remaining recursive test run was stopped after that failure.
  • The subsequent i18n and all import/platform/process/presence/public/writer/inbox boundary checks passed separately.

@Lampese
Lampese marked this pull request as ready for review October 19, 2026 22:53
@Lampese
Lampese merged commit fdd73e7 into main Oct 19, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant