Repository navigation
fix: compact the machine filter menu - #1743
Merged
Merged
Conversation
Model: gpt-6.1-sol
Model: gpt-6.1-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Same-repository UI fix; no intake issue.
Problem / pressure
The machine filter popup has two short options, but uses the regular menu width, a redundant heading and separator, and an empty leading checkbox column. This leaves Online and My machines indented inside an oversized popup even when neither filter is selected.
Summary
Use the existing compact menu width and keep only the two filter rows. Place their checkmarks after the labels using an optional
Menu.CheckboxItem indicatorSide="end"prop, matching the radio item's placement API. The reserved mark box keeps labels stable when checked; other checkbox menus retain their existing leading indicator by default.Both filters remain independent, and selecting either keeps the menu open. Update the UI gallery, package documentation, and bilingual implementation note.
Visual explanation
Actual Storybook component captures with synthetic machine fixtures, Chinese labels, and the dark theme:
Before / after
Test plan
NODE_ENV=test pnpm --filter @lody/ui exec vitest run test/menu.test.tsx test/gallery.test.tsx: 52 passed. Covers pointer and keyboard toggling with both indicator placements.pnpm --filter @lody/components exec playwright test tests/e2e/desktop-settings-layout.spec.ts --grep 'machine filters keep labels' --workers=1 --timeout=90000: both locale cases passed. Checks compact dimensions, stable label position, trailing ticks, actual filtered machine counts, keyboard toggling, and reopening.@lody/uiand@lody/componentstype checks and targeted typed lint passed.pnpm format: passed.pnpm check: passed, including workspace type checks, lint, tests, and boundary checks.pnpm check:public-boundary: passed.pnpm run docs check: reports the existing six broken Kimi/Pi submodule links in the bilingual subagent-events note; no new errors or SHA-protected topic changes.Context handoff
This is an internal, same-repository branch. The change uses the existing compact width and preserves the default shared checkbox layout. Screenshots contain repository fixtures only. Implementation decisions and verification are recorded in the owning bilingual note.