Repository navigation
feat: animate online machine halos at a constant speed - #1742
Merged
Merged
Conversation
Keep the centre steady while a separate halo expands and contracts linearly. Respect reduced motion, stop the halo offline, and add a controlled Storybook preview with a recorded GIF. Model: gpt-6.1-sol
Model: gpt-6.1-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Same-repository UI enhancement requested by the user.
Problem / pressure
The machine cards' online mark was static. The user requested an animated indicator with a constant expansion and contraction speed.
Summary
Animate a separate halo around the solid online dot: 1.4 seconds to expand, 1.4 seconds to contract, using linear timing. The centre stays fully visible and the dot keeps its existing layout box. Offline machines have no animated halo, and reduced motion keeps the online halo static.
The existing
isOnlinevalue still owns connection state. The animation adds no polling, timers, dependencies, or React updates per frame. A controlled Storybook preview makes online/offline transitions inspectable on the real card.Visual explanation
Cropped recording of the real machine card using synthetic data.
Before / after
Test plan
NODE_ENV=test pnpm --filter @lody/components exec vitest run tests/workspace-machine-accordion.test.tsx.pnpm format.pnpm check— workspace type checking, typed and Effect lint, all configured workspace tests, i18n validation, and boundary guards.pnpm run docs checkreports the same six missing local Kimi/Pi submodule links in the bilingual subagent-events note; no new broken links or protected-topic changes.Context handoff
This is a focused presentation change on a same-repository branch. The settings README and bilingual feature note document the animation, the existing presence boundary, and verification. The preview uses the production card component.