Repository navigation
fix: use available Skill detail space without scrolling - #1740
Merged
Merged
Conversation
Reserve the heading and bottom facts, then derive the description's line limit from its remaining height. Keep paths visible and cover font and list-height changes with browser regression tests. Model: gpt-6.1-sol
Model: gpt-6.1-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal same-repository change; no linked issue.
Problem / pressure
Skill previews stop after five lines even when the detail pane has unused space. Descriptions should use the available height while the skill path stays visible and the pane remains stationary under wheel input.
Summary
Visual explanation
Before / after
Test plan
NODE_ENV=test pnpm --filter @lody/components exec vitest run tests/mention-two-level-menu.test.tsx: 42 tests passed.pnpm --filter @lody/components exec playwright test tests/e2e/composer-mention-placement.spec.ts --grep 'skill descriptions use remaining height' --workers=1 --timeout=90000: passed for short and long lists at 12px, 14px, and 18px font settings.pnpm format, scoped Oxfmt/Oxlint, and whitespace checks passed.pnpm check: all workspace typechecks, general lint, Effect lint, and 58 script tests passed. The local full-workspace test run was stopped after that; it did not complete. Use PR CI status for the remaining required test validation.pnpm run docs check: six existing missing local Kimi/Pi paths in the bilingual subagent-events notes; no errors in the new note pair and no registered protected topics.Context handoff
Internal same-repository branch. This PR changes the shared neutral candidate detail pane; Agent Roles continue using their separate detail component. The implementation decision and verification limits are recorded in
.agents/notes/implemented/bug-fix/2026-10-20-mention-description-space.mdand its Chinese counterpart.