Skip to content

fix: align sidebar connection loading mark - #1738

Merged
Lampese merged 3 commits into
mainfrom
codex/sidebar-connection-working-mark
Oct 19, 2026
Merged

Lampese merged 3 commits into
mainfrom
codex/sidebar-connection-working-mark

Conversation

@Lampese

@Lampese Lampese commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Replace the sidebar connection pill's rotating spinner with the shared 3×3 WorkingGrid mark used by active session rows.
  • Preserve the existing 12px size, running tone, accessibility label, and offline state.
  • Assert the shared mark appears during syncing and stays absent offline; record the decision in a bilingual Agent Note.

Validation

  • pnpm format passed.
  • pnpm run docs check passed with existing repository-wide warnings.
  • pnpm --filter @lody/components exec vitest run tests/workspace-identity.test.tsx --maxWorkers=1 passed (9 tests).
  • pnpm check passed typecheck, lint, and Effect lint, but test:ci failed on unrelated UI test timeouts and CLI tests.
  • git diff --check passed.

@Lampese
Lampese marked this pull request as ready for review October 19, 2026 22:51
@Lampese
Lampese merged commit 5014727 into main Oct 19, 2026
16 of 17 checks passed
@Lampese
Lampese deleted the codex/sidebar-connection-working-mark branch October 19, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant