Implement user category API endpoints - #922
Merged
Merged
Conversation
jvyden
self-requested a review
August 8, 2025 20:57
jvyden
requested changes
Aug 8, 2025
…eUserResponse, properly handle unauthenticated users/me requests
jvyden
reviewed
Aug 10, 2025
Signed-off-by: jvyden <jvyden@jvyden.xyz>
Toastbrot236
added a commit
that referenced
this pull request
Feb 9, 2026
This is a refactor which removes `GameLevelCategory`, `GameUserCategory`, their equivalent game and API serialization classes and makes all category classes directly extend `GameCategory`. De-duplicating category code, especially for the API responses, was suggested in a [previous PR's review](#922 (comment)), and this is the easiest and least hacky way I could think of. While I have tried to implement the suggested strategy of using a generic type for `ApiCategoryResponse`, it became too complicated for me due to one of the two `FromOldList` methods needing to call the `Fetch` method of every category in order to add their preview items to the responses. I've thought to instead have the preview item attribute be of type `IApiResultResponse` which both `ApiGameLevelResponse` and `ApiGameUserResponse` implement. For LBP3 the `Results` attribute, which used to be in `SerializedLevelCategory` and `SerializedUserCategory`, is now in `SerializedCategory` and of type `SerializedCategoryResultsList` so the categories could include either users or levels as previews. This works with LBP3. The overridden `GameCategory.Fetch` method now returns a `DatabaseResultList`, which references a nullable `DatabaseList` of `GameLevel`s, `GameUser`s and `GamePlaylist`s each (3 lists in total). This is so that both level and user categories could override the method without any problems, while also being a preparation to make searching users for LBP1-3 and the API (and then maybe also playlists in LBP1/3/API) alongside levels possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors API category models and endpoints similarly to how their game counterparts were refactored (dedicated
CategoryApiEndpointsclass, baseApiCategoryResponseand dedicated namespace for models). Also implements API endpoints for the newly introduced user categories and a few tests for those.