fix: store the popup results per tab in session storage#25
Merged
Conversation
The single global `{ tabId, prs }` slot in `storage.local` is replaced
by `prs:${tabId}` key in `storage.session`. Then, results are stored per
tab, two forge tabs can't clobber each other, and the session area
clears itself when the browser closes.
The stored value is `{ prs }` on success or `{ error }` on failure. This
also lets the popup tell "failed" apart from "still loading".
With this fix, the popup does not read all of storage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single global
{ tabId, prs }slot instorage.localis replaced byprs:${tabId}key instorage.session. Then, results are stored per tab, two forge tabs can't clobber each other, and the session area clears itself when the browser closes.The stored value is
{ prs }on success or{ error }on failure. This also lets the popup tell "failed" apart from "still loading". With this fix, the popup does not read all of storage.