chore(model,prompts): add type annotations to module-level functions and __init__ methods#2242
Open
Koushik-Salammagari wants to merge 1 commit into
Open
Conversation
…and __init__ methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds missing Python 3.10+ style type annotations to
litgpt/model.pyandlitgpt/prompts.py. These two files had the second and third highest counts of unannotated functions afterutils.py(which was covered in #2237).litgpt/model.pyyarn_get_mscalescale: float,mscale: float,-> floatbatched_index_selectt: torch.Tensor,dim: int,idx: torch.Tensor,-> torch.Tensorbatched_index_copy_t: torch.Tensor,dim: int,idx: torch.Tensor,val: torch.Tensor,-> torch.Tensorfind_correction_dim(nested inbuild_rope_cache)num_rotations: float,dim: int,base_val: float,max_pos: int,-> floatlitgpt/prompts.pyAdded
-> Nonereturn annotation to all__init__methods that were missing it:ChatMLQwen2_5Qwen2_5_MathQwQQwen3SmolLM2SalamandraNo new imports needed in either file.
Before submitting