Skip to content

chore(data): add return type annotations to FLAN dataloader methods#2240

Open
Koushik-Salammagari wants to merge 1 commit into
Lightning-AI:mainfrom
Koushik-Salammagari:type-hints/flan-dataloader
Open

chore(data): add return type annotations to FLAN dataloader methods#2240
Koushik-Salammagari wants to merge 1 commit into
Lightning-AI:mainfrom
Koushik-Salammagari:type-hints/flan-dataloader

Conversation

@Koushik-Salammagari
Copy link
Copy Markdown

What does this PR do?

Adds missing return type annotations to three methods in litgpt/data/flan.py that were previously unannotated:

Method Added
FLAN.__post_init__ -> None
FLAN.train_dataloader -> DataLoader
FLAN.val_dataloader -> DataLoader

DataLoader was already imported at the top of the file, so no new imports are needed.

This follows the pattern established in #2221 (which bumped ruff target-version to py310) and continues the type annotation work started in #2237.

Before submitting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant