Fix division by zero in LR scheduler when max_steps equals warmup_steps#2212
Open
Br1an67 wants to merge 2 commits into
Open
Fix division by zero in LR scheduler when max_steps equals warmup_steps#2212Br1an67 wants to merge 2 commits into
Br1an67 wants to merge 2 commits into
Conversation
a88745a to
870e21b
Compare
lianakoleva
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1393
Summary
This PR fixes a division by zero error that occurs in the learning rate scheduler when
max_stepsequalslr_warmup_steps. The issue was caused by the CosineAnnealingLR scheduler receiving aT_maxvalue of 0, which results in aZeroDivisionErrorduring training.Changes
get_lr_schedulerfunction across all finetune modules (adapter.py, adapter_v2.py, full.py, lora.py, lora_legacy.py)max_steps > warmup_stepsbefore creating the schedulerTesting
The fix was verified by:
Files Changed