Skip to content

feat(vault): implement platform revenue service fee deduction in finalize_session - #71

Open
ravimahatonp wants to merge 1 commit into
LightForgeHub:mainfrom
ravimahatonp:feat/issue-31-platform-revenue-service-fee
Open

ravimahatonp wants to merge 1 commit into
LightForgeHub:mainfrom
ravimahatonp:feat/issue-31-platform-revenue-service-fee

Conversation

@ravimahatonp

Copy link
Copy Markdown

Closes #31

Overview

This PR adds percentage-based platform service fee extraction in the payment vault contract.

Key Deliverables

  • Implemented set_fee (capped at 2000 BPS / 20%) and set_treasury admin entrypoints.
  • Deducted calculated fee to Treasury on finalize_session with event emission.
  • Added regression test asserting exact token splits across user, expert, and treasury.
  • 100% Soroban tests passing locally.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 083435b1-bd76-40fd-8cd6-fa1fdbdaff0d
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Platform Revenue (Service Fee)

1 participant