Skip to content

Commit 6106b6e

Browse files
committed
fix(Sign): remove signerHasSignRequest computed and stop passing it to validator
signerHasSignRequest was added to bypass the visibleElements check in SigningRequirementValidator, causing the draw modal to open for clickToSign documents with no placed elements. With the validator fix in place, this computed and its two call-sites are no longer needed. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
1 parent bcdb5bb commit 6106b6e

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

src/views/SignPDF/_partials/Sign.vue

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -285,11 +285,6 @@ export default {
285285
canCreateSignature() {
286286
return getCapabilities()?.libresign?.config?.['sign-elements']?.['can-create-signature'] === true
287287
},
288-
signerHasSignRequest() {
289-
const doc = this.signStore.document || {}
290-
const signer = doc?.signers?.find(row => row.me) || {}
291-
return !!signer.signRequestId
292-
},
293288
ableToSign() {
294289
return this.signStore.ableToSign
295290
},
@@ -516,7 +511,6 @@ export default {
516511
errors: this.signStore.errors,
517512
hasSignatures: this.hasSignatures,
518513
canCreateSignature: this.canCreateSignature,
519-
signerHasSignRequest: this.signerHasSignRequest,
520514
})
521515
522516
const result = this.actionHandler.handleAction('sign', { unmetRequirement })
@@ -541,7 +535,6 @@ export default {
541535
errors: this.signStore.errors,
542536
hasSignatures: this.hasSignatures,
543537
canCreateSignature: this.canCreateSignature,
544-
signerHasSignRequest: this.signerHasSignRequest,
545538
})
546539
547540
const config = unmetRequirement ? { unmetRequirement } : {}

0 commit comments

Comments
 (0)