Commit bcdb5bb
committed
fix(SigningRequirementValidator): remove signerHasSignRequest shortcut that bypassed visibleElements check
The shortcut added in e9ea794 caused needsCreateSignature to return true
whenever the signer had a signRequestId, regardless of whether any visual
element box was placed. This silently opened the draw modal for clickToSign
documents with no placed elements.
Remove the shortcut and keep only the visibleElements.some() check,
also normalising signRequestId comparison to String() to be type-safe.
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>1 parent f78030e commit bcdb5bb
1 file changed
Lines changed: 1 addition & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
39 | 38 | | |
40 | 39 | | |
41 | 40 | | |
| |||
122 | 121 | | |
123 | 122 | | |
124 | 123 | | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | 124 | | |
130 | | - | |
| 125 | + | |
131 | 126 | | |
132 | 127 | | |
0 commit comments