Skip to content

Commit 34e64c4

Browse files
authored
Merge pull request #7073 from LibreSign/backport/2595/stable33
[stable33] feat: Sign usign only PHP
2 parents f25f647 + c0ea049 commit 34e64c4

23 files changed

Lines changed: 1267 additions & 33 deletions

composer.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,15 @@
5858
"OCA\\Libresign\\Tests\\Fixtures\\": "tests/php/fixtures/"
5959
}
6060
},
61+
"repositories": [
62+
{
63+
"type": "vcs",
64+
"url": "https://github.com/vitormattos/pdf-signer-php"
65+
}
66+
],
6167
"require": {
6268
"cweagans/composer-patches": "^2.0",
69+
"jeidison/signer-php": "dev-feat/visible-signature-appearance",
6370
"phpseclib/phpseclib": "^3.0"
6471
}
6572
}

composer.lock

Lines changed: 108 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/Handler/SignEngine/JSignPdfHandler.php

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -366,20 +366,24 @@ private function signUsingVisibleElements(string $normalizedPdf, string $hashAlg
366366
$params['--bg-path'] = $signatureImagePath;
367367
}
368368
} elseif ($params['--l2-text'] === '""') {
369-
if ($backgroundPathForElement) {
369+
if ($backgroundPathForElement && $signatureImagePath) {
370370
$params['--bg-path'] = $this->mergeBackgroundWithSignature(
371371
$backgroundPathForElement,
372372
$signatureImagePath,
373373
$this->normalizeScaleFactor($scaleFactor),
374374
);
375-
} else {
375+
} elseif ($backgroundPathForElement) {
376+
$params['--bg-path'] = $backgroundPathForElement;
377+
} elseif ($signatureImagePath) {
376378
$params['--bg-path'] = $signatureImagePath;
377379
}
378380
} else {
379381
if ($renderMode === SignerElementsService::RENDER_MODE_GRAPHIC_AND_DESCRIPTION) {
380382
$params['--render-mode'] = SignerElementsService::RENDER_MODE_GRAPHIC_AND_DESCRIPTION;
381383
$params['--bg-path'] = $backgroundPathForElement;
382-
$params['--img-path'] = $signatureImagePath;
384+
if ($signatureImagePath) {
385+
$params['--img-path'] = $signatureImagePath;
386+
}
383387
} elseif ($renderMode === SignerElementsService::RENDER_MODE_SIGNAME_AND_DESCRIPTION) {
384388
$params['--render-mode'] = SignerElementsService::RENDER_MODE_GRAPHIC_AND_DESCRIPTION;
385389
$params['--bg-path'] = $backgroundPathForElement;
@@ -586,7 +590,7 @@ private function parseSignatureText(): array {
586590

587591
public function getSignatureText(): string {
588592
$renderMode = $this->signatureTextService->getRenderMode();
589-
if ($renderMode !== 'GRAPHIC_ONLY') {
593+
if ($renderMode !== SignerElementsService::RENDER_MODE_GRAPHIC_ONLY) {
590594
$data = $this->parseSignatureText();
591595
$signatureText = '"' . str_replace(
592596
['"', '$'],

0 commit comments

Comments
 (0)