Repository navigation
✨ docs: Correct the Feature Pages and User Guides - #865
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 239ca1835d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | <kbd>Shift</kbd>+<kbd>Enter</kbd> | New line. | | ||
| | <kbd>Ctrl</kbd>+<kbd>Enter</kbd> (<kbd>Cmd</kbd>+<kbd>Enter</kbd>) | While a response streams: the alternate action, **send now** when <kbd>Enter</kbd> queues, or **queue** when <kbd>Enter</kbd> steers. | | ||
| | <kbd>Alt</kbd>+<kbd>Enter</kbd> (<kbd>Option</kbd>+<kbd>Enter</kbd>) | While an agent responds: interrupt and send, when available. | | ||
| | <kbd>Ctrl</kbd>+<kbd>Enter</kbd> (<kbd>Cmd</kbd>+<kbd>Enter</kbd>) | With **Press Enter to send messages** on (the default), inserts a new line, except while a response streams, where it runs the alternate action: **send now** when <kbd>Enter</kbd> queues, or **queue** when <kbd>Enter</kbd> steers. With the setting off, sends the message. | |
There was a problem hiding this comment.
This row says that Ctrl/Cmd+Enter inserts a newline when the default Press Enter to send messages setting is enabled, but the newly added default-shortcuts table in settings.mdx lists that same chord as Submit message. With shortcuts enabled by default, these instructions give users two incompatible outcomes and could cause an unintended send; document which handler takes precedence and make both tables agree.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
composer.mdx is right: resolveComposerKeyDown in client/src/utils/shortcuts.ts returns newline for Ctrl/Cmd+Enter when Enter-to-send is on. Fixed the conflicting row in settings.mdx in 00635e3 so it says Ctrl+Enter sends only when Press Enter to send messages is off.
| --- | ||
|
|
||
| **Currently, this feature is available through [Agents](/docs/features/agents), as well as through Custom Endpoints, OpenAI, Azure OpenAI, Anthropic, and Google.** | ||
| In LibreChat, RAG powers the [Agents](/docs/features/agents#file-search) **File Search** capability (`file_search`). Files attached to an agent's File Search, or to a run that selects File Search, are indexed by the RAG API and retrieved on demand. The RAG API is not used for chat endpoints other than Agents. |
There was a problem hiding this comment.
This categorically says the RAG API is not used by non-Agent chat endpoints, but the next paragraph and the updated Upload as Text documentation describe those chats calling the same API's /text route when RAG_API_URL and matching MIME configuration are present. An operator following this statement could remove the RAG service from a non-Agent deployment and break extraction for formats routed to /text; limit the exclusion to RAG indexing/retrieval rather than the entire API.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 00635e3: the sentence now limits the exclusion to RAG indexing and retrieval and points to the /text extraction path.
3a51785 to
f2e0177
Compare
f2e0177 to
b5525c4
Compare
b5525c4 to
f702b41
Compare
📦 Next.js Bundle Analysis for librechat.aiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Check the feature pages and user guides against the LibreChat client and server: fix UI labels, defaults and behavior that had drifted, describe the admin panel's layered overrides and encrypted credentials, and document the access control and insights changes.
The default shortcut list showed Ctrl+Enter as Submit message, but with Press Enter to send messages on it inserts a new line. The RAG page also said non-Agent chats never use the RAG API, although they can use its /text route for text extraction.
f702b41 to
d62abd7
Compare
📦 Next.js Bundle Analysis for librechat.aiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Summary
Checks the feature pages and user guides against the LibreChat client and server. It fixes UI labels, defaults and behavior that had drifted, and describes the admin panel's layered overrides (Base first, then priority, then role, group and user), its encrypted, masked credentials, and the access control and insights changes. Enter-to-send is described as the default, matching upstream #17374.
Stacked on #864; review only this PR's diff.
Change Type
Testing
client/src/locales/en/translation.json, behavior against the client and API on LibreChatdev, then rechecked by a second independent passChecklist