Repository navigation
🧩 docs: Update the Core librechat.yaml Reference - #862
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
d5662a6 to
e867e21
Compare
Check the top-level, interface, file, registration, balance, memory, message filter, speech, MCP and skill sync reference pages against the LibreChat config schemas, fix wrong keys and defaults, document the keys that were missing, and add a page for the deployment-owned mcpAppSandbox block.
e867e21 to
578571e
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e867e2105e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 'Origin that serves the sandbox frame. Must use http:// or https://, and must differ from the origin LibreChat is served from. If omitted, the VITE_MCP_SANDBOX_URL build-time value is used when set; without a sandbox URL, Apps are not rendered.', | ||
| 'url: "https://sandbox.example.com/"', |
There was a problem hiding this comment.
For a deployment enabling MCP Apps for the first time, setting mcpSettings.apps: true and this sandbox URL is insufficient: content/docs/configuration/dotenv.mdx documents that an unset MCP_SANDBOX_FRAME_ANCESTORS denies all embedding with frame-ancestors none. The new reference never mentions that prerequisite, so readers following it will still have their App frames blocked. Include the required environment setting with the LibreChat origin, and explain that the dedicated sandbox origin must route to /api/mcp/sandbox, as specified in content/changelog/config_v1.3.18.mdx.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 31658b6. Checked against LibreChat dev: the client uses url verbatim as the frame src (client/src/utils/mcpApps.ts:81-104) and the page is served at GET /api/mcp/sandbox (api/server/routes/mcp.js:1413), so the example and the url row now point at that route on a dedicated origin. A new "Hosting the sandbox" section says to set MCP_SANDBOX_FRAME_ANCESTORS to the LibreChat origin, since an unset value sends frame-ancestors 'none' (packages/api/src/mcp/sandbox.ts:113).
📦 Next.js Bundle Analysis for librechat.aiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
The sandbox url is the frame source itself, so it has to name the /api/mcp/sandbox route on the dedicated origin, and the page is only embeddable once MCP_SANDBOX_FRAME_ANCESTORS lists the LibreChat origin.
📦 Next.js Bundle Analysis for librechat.aiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Summary
Checks the core
librechat.yamlreference pages (top level, interface, file config, registration, balance, memory, message filters, speech, MCP servers and settings, skill sync, web search, OCR, plus the overview and full example) against the LibreChat config schemas. It fixes wrong keys and defaults, documents the keys that were missing, and adds a page for the deployment-ownedmcpAppSandboxblock, listed in every locale sidebar.The overview now says that an unknown top-level key fails validation and stops the server, which is what the strict loader does.
Stacked on #861; review only this PR's diff.
Change Type
Testing
packages/data-provider/srcon LibreChatdev, then rechecked by a second independent passpnpm check:locale-metaandpnpm check:config-versionpass; every sidebar slug resolvesChecklist