Repository navigation
🔭 feat: Support Gemini 4 Argon Input and History Rules - #620
Merged
Merged
Conversation
Gemini 4 Argon accepts image, audio, video and PDF input, but the multimodal check only recognized Gemini 1.5, 2 and 3, so the content converter rejected attachments with "This model does not support images". The check now matches Gemini 3 and any later major version. Argon histories cannot end in a model turn, so gemini-4-argon (and its variants) joins the no-prefill list and a trailing model turn is dropped before the request, as it already is for Flash 3.6+.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
7 tasks done
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa47f08f9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gemini 4 Argon (
gemini-4-argon, GA 2026-10-13) hits two predicates in the Google GenAI client that only knew earlier models._isMultimodalModelmatched Gemini 1.5, 2 and 3 only, so an image or PDF attached to an Argon turn was rejected locally with "This model does not support images", although Argon accepts image, audio, video and PDF input. And Argon histories cannot end in amodelturn, butrejectsModelTurnPrefillcovered only Flash 3.6+ and 3.5 Flash-Lite, so a resubmitted assistant turn reached Google and failed with HTTP 400.The multimodal check now matches Gemini 3 and any later major version, and
gemini-4-argon(with prefixed ids and thecyber-permissivevariant) joins the no-prefill list. Needed by LibreChat-AI/LibreChat#17200, which adds first-class Argon support.Change Type
Testing
npx jest src/llm/google/utils/common.test.ts src/llm/google/multimodal.test.ts: 18 passed; with the source change reverted, the two new Argon tests failnpx jest src/llm/google(offline suites, excluding the livellm.spec.ts): 31 passednpx tsc --noEmitand ESLint on the touched files: cleanChecklist