Repository navigation
🗂️ feat: Files & Storage and System Editors (Wave 2) - #169
Merged
Merged
Conversation
Purpose-built AI providers editor (WS9, AP-1…AP-10).
## MCP servers: purpose-built editor (WS12, MCP-1…MCP-14)
Custom endpoints editor (Wave 2, WS10).
Model specs editor (WS11, Wave 2)
Purpose-built Features tab editors (WS13).
Purpose-built editors for the Files & storage and System tabs (WS14: FX-6 to FX-13, FX-15).
danny-avila
added this pull request to stack #171
October 20, 2026 07:38
Contributor
Author
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2455ccfd86
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The configured-only filter now treats a path holding an unsaved value as set: provider groups, generic rows, sections and table-of-contents entries stay shown, so a pending edit of an unset setting never disappears behind the filter. isPathSet moves to counts.ts as the single rule.
- An inherited requiresOAuth: false no longer locks the API key and On-behalf-of methods. - Deleting a server renamed in this session lists the saved server as pending deletion, with Undo bringing the rename back. - The review pairs a removed and an added server as a rename only when the panel recorded the rename (or the values are identical), not because they share a URL or command. - Duplicate skips masked secret previews, notes which stored secrets must be entered again, and Save requires a key for an admin-provided API key. - A transport switch waiting for confirmation is planned from the current entry and dropped when the edit session ends.
# Conflicts: # src/components/configuration/ConfigTabContent.tsx
- Switching the memory agent back to an existing agent unhides a saved librechat.yaml ID tombstone, so the restored ID applies again. - Enable memory defaults to On once a pending edit adds the first memory setting, and reads inverted when shown read-only. - The domain list gives its row id to the text input, so the row label focuses it.
# Conflicts: # src/components/configuration/ConfigTabContent.tsx
…imit Editors - Skill files inherit the image and document backends, so moving them off either backend is confirmed, naming both. - Social sign-in providers are read from librechat.yaml (else LibreChat's default list), never from a stale Base override. - Resetting a sign-up domain restriction to a layer without one warns that registration opens. - Credits lists balance and transactions settings the card does not place (schema rows, then unknown keys). - "Set values only" leaves out unset skill sync sources and keeps rows that hold an unsaved value. - Rate limits say which number librechat.yaml sets when it sets only one of the pair.
Contributor
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 348b6f212a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Collapsed provider cards and groups summarized a pending API key as plain text. Secret fields (as the field renderer detects them) now show the masked placeholder; environment references stay visible.
Undo inserted a removed endpoint at its loaded position in the shortened pending list, so undoing B after deleting A and B from [A, B, C] gave [C, B]. It now goes back before the first surviving endpoint that was loaded after it.
…ues Only In a profile, the first pending edit of an inherited endpoint is not yet a stored override, so the set-values-only filter hid the row as soon as its drawer closed. Edited rows now stay listed.
Override a built-in parameter appended only { key, default }. LibreChat expands librechat.yaml definitions at startup but serves an override's as stored, and its client replaces the built-in definition with it whole, so the parameter lost its type, component and label. The full built-in definition is now stored (optionType custom, as LibreChat expands it), and a definition that differs from its built-in only in its default still opens as a default override.
The headers editor remembered every focused text input, header names included, so picking a placeholder after focusing a name wrote it into the name. Key/value inputs now carry data-kv-part, only value inputs are tracked, and with no value focused the placeholder is copied instead.
Entry ops placed removes after upserts, so a new spec's index counted entries that were about to be removed: deleting A and appending X to [A, B, C] stored [B, X, C]. Removes now come first, so every index counts only the entries that stay.
With Set values only on, a new spec ({}) hid Basics and the empty Endpoint and Model rows, so it could not be completed. A required field that is still empty (it has a required error) now stays visible.
Contributor
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dad24c5d27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
# Conflicts: # src/components/configuration/review/review.test.ts
Contributor
Author
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
danny-avila
removed this pull request from stack #171
October 23, 2026 04:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Purpose-built editors for the Files & storage and System tabs (WS14: FX-6 to FX-13, FX-15).
Files & storage
System
YAML-only settings (FX-10)
Verified in LibreChat source:
permissionsandopenapiare read only from librechat.yaml. They were editable and showed 'Changes saved' but never took effect. Both are now read-only, with explanations that say they are never applied, even after a restart.Tests
Change Type
Testing
npx tsc --noEmit(clean),npx vitest run(2097 tests pass) andnpx eslint src/ e2e/(clean).librechat.yaml: acceptance criteria at 1440 and 390 px, light and dark, with screenshots.bun run test:lint-rulesandvite buildpass.Test Configuration:
dev(data-provider 0.8.527) with MongoDB 8.2Checklist