Repository navigation
🛠️ feat: MCP Servers Editor (Wave 2) - #167
Merged
Merged
Conversation
Purpose-built AI providers editor (WS9, AP-1…AP-10).
## MCP servers: purpose-built editor (WS12, MCP-1…MCP-14)
Custom endpoints editor (Wave 2, WS10).
Model specs editor (WS11, Wave 2)
danny-avila
added this pull request to stack #171
October 20, 2026 07:38
Contributor
Author
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3fb0ac01e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The configured-only filter now treats a path holding an unsaved value as set: provider groups, generic rows, sections and table-of-contents entries stay shown, so a pending edit of an unset setting never disappears behind the filter. isPathSet moves to counts.ts as the single rule.
- An inherited requiresOAuth: false no longer locks the API key and On-behalf-of methods. - Deleting a server renamed in this session lists the saved server as pending deletion, with Undo bringing the rename back. - The review pairs a removed and an added server as a rename only when the panel recorded the rename (or the values are identical), not because they share a URL or command. - Duplicate skips masked secret previews, notes which stored secrets must be entered again, and Save requires a key for an admin-provided API key. - A transport switch waiting for confirmation is planned from the current entry and dropped when the edit session ends.
Contributor
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ebfc09eb4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Collapsed provider cards and groups summarized a pending API key as plain text. Secret fields (as the field renderer detects them) now show the masked placeholder; environment references stay visible.
Undo inserted a removed endpoint at its loaded position in the shortened pending list, so undoing B after deleting A and B from [A, B, C] gave [C, B]. It now goes back before the first surviving endpoint that was loaded after it.
…ues Only In a profile, the first pending edit of an inherited endpoint is not yet a stored override, so the set-values-only filter hid the row as soon as its drawer closed. Edited rows now stay listed.
Override a built-in parameter appended only { key, default }. LibreChat expands librechat.yaml definitions at startup but serves an override's as stored, and its client replaces the built-in definition with it whole, so the parameter lost its type, component and label. The full built-in definition is now stored (optionType custom, as LibreChat expands it), and a definition that differs from its built-in only in its default still opens as a default override.
The headers editor remembered every focused text input, header names included, so picking a placeholder after focusing a name wrote it into the name. Key/value inputs now carry data-kv-part, only value inputs are tracked, and with no value focused the placeholder is copied instead.
Entry ops placed removes after upserts, so a new spec's index counted entries that were about to be removed: deleting A and appending X to [A, B, C] stored [B, X, C]. Removes now come first, so every index counts only the entries that stay.
With Set values only on, a new spec ({}) hid Basics and the empty Endpoint and Model rows, so it could not be completed. A required field that is still empty (it has a required error) now stays visible.
Spec save issues dropped every name problem, assuming the pipeline reports them. The pipeline keys entries by the name as written, so a whitespace-only name, or names differing only by surrounding spaces, showed an inline error but left Save enabled. Only the name problems the pipeline reports itself are dropped now.
Spec search indexed every prompt field, so an OpenAI spec offered a System prompt result that opened no row. The editor and the search index now share specPromptKeys: the endpoint's prompt field, the greeting, the assistants' instructions on an assistants endpoint, and any other prompt field the preset already sets (which the editor now also shows, so a stale value stays removable).
The rename warning compared with the name captured when the Name field first mounted, which a save or scope change does not reset: after renaming A to B and saving, renaming B again showed no warning. The loaded name now comes from the pending collection edit's origin (or the current name while the list has no pending edit).
Model specs are replaced whole, but the keyed field reader fell back to the lower layer's spec of the same name, so an owned spec without a description was shown as using librechat.yaml's (or, in a profile, Base's). A layer that owns its list now stops lower values from counting as effective, configured or in the provenance stack; the same-named lower entry stays only as the revert target.
Switching an agents spec to another endpoint kept agent_id in the preset, while the editor hid the Agent field and left agent_id out of the parameter rows, so the stale value could be neither seen nor removed. Leaving the agents endpoint now clears it, and an agent ID a non-agents spec still stores (e.g. from librechat.yaml) is shown as a removable row.
…ords on Delete Renaming a saved MCP server writes it under a new name without its stored secrets (only their masked previews are loaded), and nothing blocked saving a renamed OAuth server without its client secret. A renamed server now lists the stored secrets to enter again, and Save is blocked until they are, using the page's rename records. Deleting a renamed server only cleared the card's local rename note, so the page still recorded the rename and the review paired an unrelated new server of that name with it. Deleting it now drops the rename record (onRenameEntry(from, null)), and Undo records it again.
…es Only In a profile with Set values only, choosing Override for an inherited server from Create only unlocked it, but the filter still dropped the card (no profile value yet), and its fields would have been filtered too. An unlocked server now stays listed with all of its fields, so the first override can be entered.
copyName tested candidates case-sensitively while server names must be unique in any letter case, so duplicating Docs next to docs-copy created Docs-copy. Candidates are now compared lowercased.
The admin API returns a stored apiKey.key or oauth.client_secret only as its preview companion, but MCP fields passed no preview to the control, so a configured credential looked like an empty password input. The row now shows the masked preview with Replace, and Cancel discards the replacement.
Contributor
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 666288f141
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
danny-avila
removed this pull request from stack #171
October 23, 2026 04:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MCP servers: purpose-built editor (WS12, MCP-1…MCP-14)
This replaces the generic schema form on the MCP tab with an editor built for MCP servers. The new code is in
components/configuration/sections/mcp/.Server cards
Fields, grouped by purpose
Transport (MCP-1, MCP-2)
Authentication (MCP-4)
Other fields (MCP-6 – MCP-8)
Create flow (MCP-9)
Profiles (MCP-10)
Filters and settings (MCP-11, MCP-13)
Outside sections/mcp
onHideField,onUnhideFieldandonRenameEntryare passed to section renderers. The edit state records each server renamed in the panel, so the review pairs a removal and an addition as a rename only when that rename was made (or the two are identical), never because they share a URL or command.meta/mcp.ts.Tests
e2e/mcp.spec.ts, gated by E2E_LIVE=1.Change Type
Testing
npx tsc --noEmit(clean),npx vitest run(1986 tests pass) andnpx eslint src/ e2e/(clean).librechat.yaml: acceptance criteria at 1440 and 390 px, light and dark, with screenshots.bun run test:lint-rulesandvite buildpass.Test Configuration:
dev(data-provider 0.8.527) with MongoDB 8.2Checklist