Repository navigation
ποΈ refactor: Move Pane Composer Files to Jotai in the Chat Package - #17193
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
berry-13
added this pull request to stack #17195
October 16, 2026 21:03
berry-13
force-pushed
the
refactor/chat-pane-files
branch
from
October 16, 2026 21:05
810f98a to
42e672f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
The files staged in each chat pane's composer lived in a Recoil atom family (
filesByIndexinclient/src/store/families.ts), souseChatHelpers,useNewConvo,useNewChat, the files table and the sign-out reset all reached into~/storefor state that only the chat pane owns.This moves that state to a Jotai family,
filesFamily, underpackages/chat/src/react/pane/(exported from@librechat/chat/react) together with all six consumers. TheExtendedFiletype the family holds moves topackages/chat/src/core/files.ts;~/commonre-exports it, so existing imports are unchanged. Behavior is the same: each pane starts with an empty map, and sign-out clears every pane except the kept first one.Stacked on #17179, which moves the pane preset and option settings the same way; both edit the same consumers. This continues moving feature-owned chat state onto Jotai inside the chat package and cutting the chat hooks' reads of
~/store.Type of change
Testing
Tested environments/configuration:
Automated tests:
pane.spec.tsnow covers the files family's empty default and per-pane isolation.useClearStatesper-pane reset case now also asserts that staged files are cleared on sign-out.RecoilRoot. TheuseNewChatanduseNewConvospecs back their file maps with the real atom instead of a mocked Recoil hook.npx jestoverChat/Input(including the files table),hooks/Chat/__tests__,useClearStates,hooks/Conversations,useNewConvoandChat/Menus: 91 suites, 1662 tests passed.npm run typecheckinclientandpackages/chat: no errors. ESLint, Prettier and import sorting clean on the changed files.Screenshots / recordings
No user-facing change.