Repository navigation
馃帹 style: Restore Resumable SSE Import Order - #17191
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
馃煝 Approval recommended
The formatting-only change restores import order and has no identified issues.
0 open findings
What changed in this PR
Restores the required package import order in useResumableSSE.ts after #17129, addressing the import-sorting check failure.
Changes:
- Moves the
@librechat/chat/reactimport afterlibrechat-data-provider, with no runtime logic changes.
| File | Description |
|---|---|
| client/鈥媠rc/鈥媓ooks/鈥婼SE/鈥媢seResumableSSE.ts | Reorders package imports to match repository sorting rules. |
馃 Review effort: Balanced
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dustinhealy
marked this pull request as ready for review
October 16, 2026 19:24
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#17129 shortened the
librechat-data-providerimport inuseResumableSSE.ts, leaving it after the longer@librechat/chat/reactimport. The import-sorting check now fails ondevand branches that include that change.Move the
librechat-data-providerblock above@librechat/chat/reactto restore the required order.Related to #17129.
Type of change
Testing
Tested environments/configuration: Node.js 24.16.0 on macOS.
Automated tests:
Reproduced the import-sort failure on
devwithnode scripts/sort-imports.mts --check client/src/hooks/SSE/useResumableSSE.ts.npm run static-checks -- client/src/hooks/SSE/useResumableSSE.tspasses ESLint, Prettier, import sorting, package validation, and design-rule suppression checks after the fix.git diff --checkpasses.Client
tsc --noEmitencountered stale workspace declaration exports in the reused local dependency installation. The fresh CI client typecheck passes.CI import sorting, client typechecking, Lighthouse, and MCP Apps pass. The UI-scale conversation-row E2E scenario times out after switching to 150% scale, including both retries.
Screenshots / recordings
N/A.
Checklist