🔲 refactor: Route Picker Panels Through Theme Radius Roles

[berry-13]

Pull Request

Summary

The form-control picker panels (TimePicker, ControlCombobox, MultiSelect) and the date range picker drew a literal rounded-xl or rounded-lg, so a theme could only reshape them by moving every control on that radius step. This routes the three pickers through the existing menu panel role (menuPanelRadius, 0.75rem, the corner they already drew) and gives the date range picker a compactPanelRadius role (0.5rem, inheriting radiusLg), so the default theme stays pixel-identical and ClickHouse squares them to its Click UI menu corner. Closes berry-13#280.

The account menu and its help submenu needed no role: they are .popover-ui panels, and that unlayered rule already paints menuRadius over the rounded-lg utility they carried, so the class never applied. It is dropped, and the Prompts variables menu and the Variables editor menu already delegate their corners to DropdownPopup. The panel radius guard spec now scans these files and fails on a panel that styles its own corners without a role.

Type of change

• Refactor

Testing

Tested environments/configuration:

• Chromium through the mock e2e harness, default and ClickHouse themes, light and dark

Automated tests:

• e2e/specs/mock/scenarios/panel-shape.spec.ts: the account menus keep the menu corner in the default theme (11.2px), follow ClickHouse's menu corner (4px), and follow a reference theme that names only menuRadius
• panelRadius.spec.ts guard extended to the picker, date range and account files; it fails for each of the five changed files when that file is reverted to dev
• packages/client theme suites (registry inheritance from radiusLg, Tailwind utility mapping, defaults, ClickHouse and Click UI source pins): 627 passed
• npm run typecheck in client, tsc --noEmit in packages/client, ESLint, Prettier and import order on the changed files

Screenshots / recordings

The time zone picker in the schedule dialog, base revision against this branch. The default theme is pixel-identical (an image diff of the panel is empty in light and dark); ClickHouse moves from 8px to its 4px menu corner.

Theme	Before	After
Default light
Default dark
ClickHouse light
ClickHouse dark

Risk / compatibility

A stored or inline theme definition that sets radiusLg and not compactPanelRadius keeps the corner the date range picker drew before, through the inheritance pair. compactPanelRadius is a new optional appearance key validated as a length.

Checklist

• I reviewed my own changes
• Relevant tests have been added or updated
• Existing relevant tests pass
• The change does not introduce new warnings or errors
• User-facing or complex behavior is documented where necessary

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-16T22:58:36.767155Z	e9c7c09	New commits
🔒 Security Review	✅ Completed 2026-10-16T19:37:52.770522Z	f5c1775	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.