Skip to content

🗂️ refactor: Read the Search, File and Message Editor Siblings Through the Parts Host - #17173

Merged
berry-13 merged 1 commit into
devfrom
refactor/chat-parts-overlap
Oct 16, 2026
Merged

berry-13 merged 1 commit into
devfrom
refactor/chat-parts-overlap

Conversation

@berry-13

Copy link
Copy Markdown
Collaborator

Summary

Four Messages/Content siblings still read the app directly: SearchContent (the user markdown preference from Recoil, and the message context it re-provides to error parts), Files and FilePreviewDialog (the file map context, and the user atom), and EditMessage (chat direction from Recoil, the messages view providers).

This routes them through the parts host members the two earlier links added or already had: useUserTextPreferences, useFileMap, useUser, useChatDirection and useMessagesEditing. For SearchContent, the package gains MessagePartIndex, which provides the surrounding message to one part at its position, so the sibling no longer reads and respreads MessageContext itself.

This link is kept separate because each file overlaps an open contributor PR: SearchContent with #16496 and #16518, Files with #17017, FilePreviewDialog with #16282, and EditMessage with #16204 and #17017. Every change here is a few lines at the top of the component, so those branches rebase trivially; it can merge now or wait for them. Stacked on #17172.

Type of change

  • Refactor

Testing

Tested environments/configuration:

Local jest and typecheck; no runtime configuration matters for this change.

Automated tests:

Screenshots / recordings

No user-facing change.

Risk / compatibility

Low. Each read returns what the component read before through the app's host, and MessagePartIndex provides the same value the inline spread did.

Checklist

  • I reviewed my own changes
  • Relevant tests have been added or updated
  • Existing relevant tests pass
  • The change does not introduce new warnings or errors

@berry-13
berry-13 marked this pull request as ready for review October 15, 2026 18:02
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T20:50:15.094600Z e665669 New commits
🔒 Security Review ✅ Completed 2026-10-15T18:04:52.866510Z bcc0f8d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codegraph-librechat codegraph-librechat Bot added the 🗺️ Client UI Foundation codegraph: the taxonomy area this belongs to (classifier, confidence ≥ 0.9) label Oct 15, 2026
@berry-13
berry-13 added this pull request to stack #17183 October 16, 2026 13:03
@berry-13
berry-13 force-pushed the refactor/chat-parts-overlap branch from bcc0f8d to 81cfece Compare October 16, 2026 20:05
Copilot AI balanced review requested due to automatic review settings October 16, 2026 20:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Base automatically changed from refactor/chat-parts-editing to dev October 16, 2026 20:48
@berry-13
berry-13 force-pushed the refactor/chat-parts-overlap branch from 81cfece to e665669 Compare October 16, 2026 20:48
@berry-13
berry-13 merged commit 8137a8f into dev Oct 16, 2026
42 checks passed
@berry-13
berry-13 deleted the refactor/chat-parts-overlap branch October 16, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗺️ Client UI Foundation codegraph: the taxonomy area this belongs to (classifier, confidence ≥ 0.9)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants