Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
4 tasks done
berry-13
added this pull request to stack #17153
October 15, 2026 13:49
berry-13
force-pushed
the
refactor/chat-resumable-bindings
branch
from
October 15, 2026 15:42
97c89cf to
f4d8d97
Compare
berry-13
force-pushed
the
refactor/chat-resumable-bindings
branch
from
October 16, 2026 19:38
f4d8d97 to
d63d52d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
With the resumable run in
@librechat/chatcore,useResumableSSEwas left as one long hook that built everything the run needs from the app: the steer-chip adapter, the query cache adapter, the pane controls and queue-drain markers, and the event and usage handlers. Those are four separate concerns that each read different app state.This splits it by responsibility into thin bindings in
client/src/hooks/SSE/:useResumableSteers(adapts the steer state fromuseSteerState()inhooks/SSE/steer.tsto the run's steer host, adding queue restore and recovery bookkeeping),useResumableCache(the cache, active jobs and the new chat's optimistic records),useResumablePane(controls, generation epochs, run end and the detached-run markers) anduseResumableEvents(the event and usage handlers and the error cards). Each returns one group of theResumableHost;useResumableSSEcomposes them and callsmountSubmission, and is now 142 lines (from 4,964 before this stack). No behavior changes. Stacked on #17132.Type of change
Testing
Tested environments/configuration:
Not applicable: the bindings are moved, not changed.
Automated tests:
useResumableSSE.spec.tsimportsselectLocalSteersForQueueandABORT_SWEEP_STATUSESfrom their new home; nothing else in the specs changed.client, the hooks/SSE and hooks/Chat specs plus data-provider/SSE: 1148 pass.npx tsc --noEmitinclient, eslint, prettier and sort-imports on the changed files: clean.Screenshots / recordings
No user-facing change.
Risk / compatibility
The host groups are memoized per hook, so a render that changes one handler rebuilds only its group; the host a subscription captured still comes from the render that attached it.
Checklist