-
-
Notifications
You must be signed in to change notification settings - Fork 3
62 build times are too high for test saturate #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
albertandaluz
merged 6 commits into
main
from
62-build-times-are-too-high-for-test_saturate
Sep 13, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3bfb03f
parallel implementation of utest saturate and utest_cuda_vector_utils
e094631
disable CPU backend compilation for visual studio 2017 since it is no…
82cebfe
Merge branch 'main' into 62-build-times-are-too-high-for-test_saturate
f193cf0
upgraded clang to 21.1.0
268d3f9
Fixed folder ide string
e5901ae
Removing dead code
morousg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| set (LAUNCH_SOURCES "${CMAKE_SOURCE_DIR}/tests/main.cpp;${CMAKE_SOURCE_DIR}/tests/main.h") | ||
| if (WIN32) | ||
| list(APPEND LAUNCH_SOURCES "${CMAKE_SOURCE_DIR}/manifest.xml") #for utf8 codepage | ||
| endif() | ||
|
|
||
| function(add_cuda_to_test TARGET_NAME) | ||
| add_cuda_to_target(${TARGET_NAME} "") | ||
| set_target_cuda_arch_flags(${TARGET_NAME}) | ||
|
|
||
| if(${ENABLE_DEBUG}) | ||
| add_cuda_debug_support_to_target(${TARGET_NAME}) | ||
| endif() | ||
| if(${ENABLE_NVTX}) | ||
| add_nvtx_support_to_target(${TARGET_NAME}) | ||
| endif() | ||
| endfunction() | ||
|
|
||
| function (add_generated_test TARGET_NAME TEST_SOURCE EXTENSION DIR) | ||
|
|
||
| set(TEST_GENERATED_SOURCE "${CMAKE_CURRENT_BINARY_DIR}/${TARGET_NAME}_${EXTENSION}/launcher.${EXTENSION}") #use the same name as the target ) | ||
|
|
||
| configure_file(${CMAKE_SOURCE_DIR}/tests/launcher.in ${TEST_GENERATED_SOURCE} @ONLY) #replace variables in the test source file | ||
| set (TARGET_NAME_EXT "${TARGET_NAME}_${EXTENSION}") | ||
| #message(STATUS "Adding test: ${TARGET_NAME_EXT} from ${TEST_GENERATED_SOURCE} and ${TEST_SOURCE}") | ||
| add_executable(${TARGET_NAME_EXT} "${TEST_GENERATED_SOURCE};${TEST_SOURCE}" ) | ||
| target_sources(${TARGET_NAME_EXT} PRIVATE ${LAUNCH_SOURCES}) | ||
|
|
||
| if(${ENABLE_BENCHMARK}) | ||
| target_compile_definitions(${TARGET_NAME_EXT} PRIVATE ENABLE_BENCHMARK) | ||
| endif() | ||
|
|
||
| set_target_properties(${TARGET_NAME_EXT} PROPERTIES CXX_STANDARD 17 CXX_STANDARD_REQUIRED YES CXX_EXTENSIONS NO) | ||
| target_include_directories(${TARGET_NAME_EXT} PRIVATE "${CMAKE_SOURCE_DIR}") | ||
| target_include_directories(${TARGET_NAME_EXT} PRIVATE "${DIR}") | ||
| target_link_libraries(${TARGET_NAME_EXT} PRIVATE FKL::FKL) | ||
| target_link_libraries(${TARGET_NAME_EXT} PRIVATE CUDA::cuda_driver) | ||
| if (NVRTC_ENABLE) | ||
| target_link_libraries(${TARGET_NAME_EXT} PRIVATE ${NVRTC_LIBRARIES}) | ||
| target_compile_definitions(${TARGET_NAME_EXT} PRIVATE NVRTC_ENABLE) | ||
| if (MSVC) | ||
| if (NVRTC_STATIC_LINK) | ||
| set_target_properties(${TARGET_NAME_EXT} PROPERTIES MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>") | ||
| endif() | ||
| endif() | ||
| endif() | ||
| if (MSVC) | ||
| target_compile_options(${TARGET_NAME_EXT} PRIVATE $<$<COMPILE_LANGUAGE:CXX>:/diagnostics:caret>) | ||
| endif() | ||
|
|
||
| add_optimization_flags(${TARGET_NAME_EXT}) | ||
|
|
||
| add_test(NAME ${TARGET_NAME_EXT} COMMAND ${TARGET_NAME_EXT}) | ||
| cmake_path(SET path2 "${DIR}") | ||
| cmake_path(GET path2 FILENAME DIR_NAME) | ||
| set_property(TARGET "${TARGET_NAME_EXT}" PROPERTY FOLDER "tests/${EXTENSION}/${DIR_NAME}") | ||
|
|
||
| endfunction() | ||
|
|
||
| function (discover_tests DIR) | ||
| file( | ||
| GLOB_RECURSE | ||
| TEST_SOURCES | ||
| CONFIGURE_DEPENDS | ||
| "${DIR}/*.h" | ||
| ) | ||
|
|
||
| foreach(test_source ${TEST_SOURCES}) | ||
|
|
||
| get_filename_component(TARGET_NAME ${test_source} NAME_WE) | ||
| cmake_path(GET test_source PARENT_PATH DIR_NAME) #get the directory name of the test source file | ||
| string(FIND ${DIR_NAME} "cudabug" POS) | ||
| if (${POS} EQUAL -1) #if the directory name does not contain "cudabug" | ||
| if (${ENABLE_CPU}) | ||
| add_generated_test("${TARGET_NAME}" "${test_source}" "cpp" "${DIR_NAME}") | ||
| endif() | ||
| endif() | ||
| if (CMAKE_CUDA_COMPILER AND ENABLE_CUDA) | ||
| add_generated_test("${TARGET_NAME}" "${test_source}" "cu" "${DIR_NAME}") | ||
| add_cuda_to_test("${TARGET_NAME}_cu") | ||
| endif() | ||
|
|
||
| endforeach() | ||
| endfunction() | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
|
|
||
|
|
||
| macro(add_generated_export_header_to_target TARGET_NAME) | ||
| include(GenerateExportHeader) | ||
| generate_export_header(${TARGET_NAME} EXPORT_FILE_NAME "${CMAKE_BINARY_DIR}/exports/${TARGET_NAME}_export.h") | ||
| target_include_directories(${TARGET_NAME} PUBLIC "${CMAKE_BINARY_DIR}/exports/") | ||
| set_target_properties(${TARGET_NAME} PROPERTIES CXX_VISIBILITY_PRESET default) | ||
| target_sources(${TARGET_NAME} PRIVATE "${CMAKE_BINARY_DIR}/exports/${TARGET_NAME}_export.h") | ||
| endmacro() |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,36 @@ | ||||||||||||||
| function (add_generated_lib TARGET_NAME TEST_SOURCES DIR) | ||||||||||||||
| add_library(${TARGET_NAME} SHARED "${TEST_SOURCES}" ) | ||||||||||||||
| set_target_properties(${TARGET_NAME} PROPERTIES LINKER_LANGUAGE CXX) | ||||||||||||||
| add_generated_export_header_to_target(${TARGET_NAME}) | ||||||||||||||
| configure_test_target_flags("${TARGET_NAME}" "${TEST_SOURCES}" "${DIR}") | ||||||||||||||
| set_property(TARGET "${TARGET_NAME}" PROPERTY FOLDER "${DIR}") | ||||||||||||||
| endfunction() | ||||||||||||||
|
|
||||||||||||||
| function (add_shared_target TARGET_BASE_NAME EXTENSION FUNDAMENTAL_TYPE DIR) | ||||||||||||||
| string(TOUPPER ${FUNDAMENTAL_TYPE} FUNDAMENTAL_TYPE_UPPER) | ||||||||||||||
| string(TOUPPER ${EXTENSION} EXTENSION_UPPER) | ||||||||||||||
| set (GEN_DIR ${TARGET_BASE_NAME}_${FUNDAMENTAL_TYPE}_${EXTENSION}) | ||||||||||||||
| configure_file(${CMAKE_CURRENT_SOURCE_DIR}/${TARGET_BASE_NAME}_ftype.h.in | ||||||||||||||
| ${CMAKE_BINARY_DIR}/generated/${GEN_DIR}/${GEN_DIR}.h) | ||||||||||||||
|
|
||||||||||||||
| configure_file(${CMAKE_CURRENT_SOURCE_DIR}/${TARGET_BASE_NAME}_ftype.${EXTENSION}.in | ||||||||||||||
| ${CMAKE_BINARY_DIR}/generated/${GEN_DIR}/${GEN_DIR}.${EXTENSION}) | ||||||||||||||
|
|
||||||||||||||
| set(SOURCES "${CMAKE_CURRENT_SOURCE_DIR}/${TARGET_BASE_NAME}_common.h" | ||||||||||||||
| ${CMAKE_BINARY_DIR}/generated/${GEN_DIR}/${GEN_DIR}.h | ||||||||||||||
| ${CMAKE_BINARY_DIR}/generated/${GEN_DIR}/${GEN_DIR}.${EXTENSION}) | ||||||||||||||
|
|
||||||||||||||
| add_generated_lib("${TARGET_NAME}_${EXTENSION}" "${SOURCES}" "${DIR}") | ||||||||||||||
|
||||||||||||||
| target_include_directories("${TARGET_NAME}_${EXTENSION}" PUBLIC "${CMAKE_CURRENT_SOURCE_DIR}/") #testcommon | ||||||||||||||
| target_include_directories("${TARGET_NAME}_${EXTENSION}" PUBLIC "${CMAKE_BINARY_DIR}/generated/${GEN_DIR}/") #testcommon | ||||||||||||||
|
Comment on lines
+23
to
+25
|
||||||||||||||
| add_generated_lib("${TARGET_NAME}_${EXTENSION}" "${SOURCES}" "${DIR}") | |
| target_include_directories("${TARGET_NAME}_${EXTENSION}" PUBLIC "${CMAKE_CURRENT_SOURCE_DIR}/") #testcommon | |
| target_include_directories("${TARGET_NAME}_${EXTENSION}" PUBLIC "${CMAKE_BINARY_DIR}/generated/${GEN_DIR}/") #testcommon | |
| add_generated_lib("${TARGET_BASE_NAME}_${FUNDAMENTAL_TYPE}_${EXTENSION}" "${SOURCES}" "${DIR}") | |
| target_include_directories("${TARGET_BASE_NAME}_${FUNDAMENTAL_TYPE}_${EXTENSION}" PUBLIC "${CMAKE_CURRENT_SOURCE_DIR}/") #testcommon | |
| target_include_directories("${TARGET_BASE_NAME}_${FUNDAMENTAL_TYPE}_${EXTENSION}" PUBLIC "${CMAKE_BINARY_DIR}/generated/${GEN_DIR}/") #testcommon |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.