359 fix fuse case readiopthenbatchreadincompletereadbackiop - #360
Merged
morousg merged 3 commits intoAug 26, 2026
Merged
Conversation
…before making it Incomplete type instead of using the TypeList trick.
…s to be defined as also Incomplete
morousg
deleted the
359-fix-fuse-case-readiopthenbatchreadincompletereadbackiop
branch
August 26, 2026 20:28
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes fusion between a read IOp and batched incomplete ReadBack operations.
Changes:
- Adds an incomplete ReadBack trait.
- Supports array-backed operation data.
- Refactors
BatchReadaround operation parents and incomplete-operation handling.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
operation_types.h |
Adds incomplete ReadBack detection. |
operation_data.h |
Adds constrained constructors and array copying. |
batch_operations.h |
Updates batched read construction and fusion behavior. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| using Parent = ReadOperation<typename Op::ReadDataType, | ||
| BatchReadParams<BATCH, PP, Operation, typename Op::OutputType>, | ||
| typename Op::OutputType, | ||
| static_cast<TF>(Operation::THREAD_FUSION), SelfType, false>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.