Fix Warping Operation - #357
Merged
Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Warping ReadBack operation’s declared OutputType so it is derived from the upstream BackIOp’s actual output type rather than its original ReadDataType, aligning Warping’s type contract with what InterpolateComplete returns.
Changes:
- Update
Warping’sReadBackOperationparent type to usecn<typename BackIOp_::Operation::OutputType>(instead ofReadDataType) when formingfloat_<...>output. - Prevent type mismatches when
Warpingis fused after aBackIOpthat changes channel count/type (e.g., conversions/reductions before the warp).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.