Fixing a recurrent compilation issue related to double definition of … - #332
Merged
morousg merged 1 commit intoAug 10, 2026
Conversation
…cuda vector types
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts how CUDA vector_types.h is detected/included to avoid type redefinition conflicts and improve compatibility across CUDA toolchains.
Changes:
- Expands the preprocessor guard to include CUDA compilation macros beyond
__NVCC__. - Treats
__VECTOR_TYPES_H__as a signal to include CUDA’svector_types.h.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
morousg
deleted the
331-fix-compilation-issues-related-to-double-definition-of-vector-types
branch
August 10, 2026 18:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cuda vector types