Repository navigation
Conversation
GitHub does not play a committed mp4 inside the README, so the poster links to the file. The English README uses absolute URLs because it is the PyPI long description. The mp4 stays out of the sdist. Co-authored-by: Lexus2016 <Lexus2016@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the 30-second promo (9:16, English voiceover and subtitles) so it shows up right after the title, badges, and intro, before the install sections.
GitHub does not play a repository mp4 inside a README, so each README uses a clickable poster (300px wide) that links to the mp4 on GitHub, with a short caption.
assets/turbo-quant-memory-promo.mp4assets/turbo-quant-memory-poster.jpg— a frame of the memory tools in the terminal; kept as the poster because it shows the product more clearly than the title cardsREADME.mdis the PyPI long description, so its poster and link are absolute (raw.githubusercontent.comfor the image,github.com/.../blob/main/...for the mp4). A relative image there is what left a blank hero on PyPI in 0.28.2.README.uk.mdandREADME.ru.mdkeep relative paths, the same way their heroes do, and those are the paths GitHub rewrites when it renders the file (rawfor the image,blobfor the mp4).The mp4 is excluded from the sdist (
/assets/*.mp4). The poster JPEG stays with the other README assets. Confirmed with a localhatchling build -t sdist: the archive contains the poster and not the mp4.Test plan
README.uk.mdandREADME.ru.mdand confirm the poster renders at about 300px wide and both the image and the caption openassets/turbo-quant-memory-promo.mp4in GitHub's playerREADME.md(the absolutemainURLs 404 until the files are onmain)