Repository navigation
fix(engine): don't send the first message before the real default loads - #103
Closed
Its-My-Work wants to merge 1 commit into
Closed
Its-My-Work wants to merge 1 commit into
Its-My-Work wants to merge 1 commit into
Conversation
_globalDefaultEngine starts hardcoded 'api' and only becomes the actual configured default once checkVersion()'s /api/version fetch resolves and calls resolveEngineForView(). A message sent before that fetch landed — in practice, the very first message on a freshly loaded page — went out with curEngine still on that placeholder 'api'. The server bakes whatever `engine` arrives into the session's run_engine permanently (server.js ~11914), so this silently and irreversibly routed that chat's billing through the API key instead of the user's actually configured Subscription default, for the life of the chat. Capture checkVersion()'s promise as _versionCheckDone and await it at the top of send() — a no-op once already resolved, so this costs nothing beyond the first message of a session. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011E2bJQ2sL9LgEWosjvydTR
Contributor
Author
Lexus2016
added a commit
that referenced
this pull request
Oct 7, 2026
…the first send, sync the mobile chips (#127) Three ways the UI and the chat disagree about the engine. #103 and #105 proposed two of them and were withdrawn because they did not cure the reported 402; verifying them in a browser found the cause they both missed. - checkVersion() called loadTerminalCapability() before it stored the default engine, and that helper lives in the last script block. A reply landing before the parser reached it threw a ReferenceError into checkVersion's own catch{}, skipping the configured engine, the chat defaults and loadBots(). The default is now stored right after applyTmuxCapability(), ahead of every call that can throw. - send() read curEngine on its 'api' placeholder before /api/version had landed. It now awaits engineDefaultReady(): bounded by VERSION_WAIT_MS, skipped for a user who already clicked an engine chip (_engineUserPicked), and tied to the local version reply only (the GitHub release lookup moved to _checkLatestRelease(), not awaited). - syncMobSheetFromDesktop() had no engine branch, so opening the mobile sheet blanked both engine chips. The wait's two extra rules came from an independent review (codex, agy) of the first version; both defects were reproduced before they were fixed. test/render/engine-default.test.mjs: 18 tests, each watched failing first. CLAUDE.md test counts corrected (101 = 20 + 81).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_globalDefaultEnginestarts hardcoded'api'and only becomes the actual configured default oncecheckVersion()'s/api/versionfetch resolves and callsresolveEngineForView(). A message sent before that fetch lands — in practice, the very first message on a freshly loaded page — went out withcurEnginestill on that placeholder'api'.The server bakes whatever
enginearrives into the session'srun_enginepermanently (server.js~line 11914), so this silently and irreversibly routed that chat's billing through the API key instead of the user's actually-configured Subscription default, for the life of the chat.Fix
Capture
checkVersion()'s promise as_versionCheckDoneandawaitit at the top ofsend()— a no-op once already resolved, so this costs nothing beyond the first message of a session.Verified
run_engine='api'explicitly set even though the configured default was'subscription'— neverNULL(which would mean "inherit the default").Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_011E2bJQ2sL9LgEWosjvydTR