Do not create remove_bad_files.sh

src/deadCode.ml

@@ -24,7 +24,7 @@ open DeadCommon
 
                 (********   ATTRIBUTES   ********)
 
-let bad_files = ref []                (* unreadable cmti/cmt files *)
+let bad_files_counter = ref 0                 (* unreadable cmti/cmt files *)
 
 let main_files = Hashtbl.create 256   (* names -> paths *)
 
@@ -472,29 +472,29 @@ let eof loc_dep =
 
 (* Starting point *)
 let load_file fn state =
+  let report_error err =
+    if state.State.config.verbose then
+      Printf.eprintf "ERROR: %s\n%!" err;
+    incr bad_files_counter
+  in
   let init_and_continue state fn f =
     match State.change_file state fn with
     | Error msg ->
-      Printf.eprintf "%s\n%!" msg;
+      report_error msg;
       state
     | Ok state ->
         State.update state;
         f state;
         (* TODO: stateful computations should take and return the state when possible *)
         state
   in
-  let add_bad_file err fn =
-    if state.State.config.verbose then
-      Printf.eprintf "%s\n%!" err;
-    bad_files := fn :: !bad_files
-  in
   let process_interface fn =
     last_loc := Lexing.dummy_pos;
       if state.State.config.verbose then
         Printf.eprintf "Scanning interface from %s\n%!" fn;
     init_and_continue state fn (fun state ->
     match state.file_infos.cmi_sign with
-    | None -> add_bad_file "Missing cmi_sign" fn
+    | None -> report_error (fn ^ ": missing cmi_sign")
     | Some cmi_sign ->
         read_interface fn cmi_sign state
     )
@@ -505,7 +505,7 @@ let load_file fn state =
       Printf.eprintf "Scanning implementation from %s\n%!" fn;
     init_and_continue state fn (fun state ->
     match state.file_infos.cmt_struct with
-    | None -> add_bad_file "Missing cmt_struct" fn
+    | None -> report_error (fn ^ ": missing cmt_struct")
     | Some structure ->
         regabs state;
         let prepare (loc1, loc2) =
@@ -724,6 +724,16 @@ try
 
     Printf.eprintf " [DONE]\n\n%!";
 
+    let _report_bad_files =
+      let bad_files_count = !bad_files_counter in
+      if bad_files_count > 0 && not state.State.config.verbose then
+        let file_string = if bad_files_count = 1 then "file" else "files" in
+        Printf.eprintf
+          "*** WARNING: %d %s cannot be read. Run with `--verbose` for more details.\n\n%!"
+          bad_files_count
+          file_string;
+    in
+
     !DeadLexiFi.prepare_report DeadType.decs;
     let sections = state.config.sections in
     if Config.must_report_section sections.exported_values then report_unused_exported ();
@@ -737,16 +747,6 @@ try
     let style = sections.style in
     if style.opt_arg || style.unit_pat || style.seq || style.binding then
       report_style ();
-
-    if !bad_files <> [] then begin
-      let oc = open_out_bin "remove_bad_files.sh" in
-      Printf.fprintf oc "#!/bin/sh\n";
-      List.iter
-        (fun x -> Printf.fprintf oc "rm %s\n" x)
-        !bad_files;
-      close_out oc;
-      Printf.eprintf "*** INFO: Several binary files cannot be read.  Please run ./remove_bad_files.sh to remove them.\n%!"
-    end
   with exn ->
     Location.report_exception Format.err_formatter exn;
     exit 2

src/state/cmt.ml

@@ -46,11 +46,22 @@ let print_cache_stats () =
 
 
 let read_no_cache filepath =
+  let error ?tip msg =
+    let tip =
+      Option.map (( ^ ) " Tip: ") tip
+      |> Option.value ~default:""
+    in
+    Printf.sprintf "%s: %s.%s" filepath msg tip
+    |> Result.error
+  in
   match Cmt_format.read filepath with
-  | exception _ -> Result.error (filepath ^ ": error reading file")
-  | _, None -> Result.error (filepath ^ ": cmt_infos not found")
-  | cmi_infos, Some cmt_infos ->
-    Result.ok (cmi_infos, cmt_infos)
+  | exception Cmi_format.(Error (Not_an_interface _)) ->
+      let tip =
+        "the file must be compiled with the same OCaml version as the dead_code_analyzer."
+      in
+      error ~tip "invalid magic number"
+  | _, None -> error "missing cmt_infos"
+  | cmi_infos, Some cmt_infos -> Result.ok (cmi_infos, cmt_infos)
 
 let read filepath =
   let comp_unit = Utils.Filepath.unit filepath in