Strengthened condemnation/displacement warnings - #661
Merged
Conversation
…tes with help text; added help text with notice to get_inspection question; edited note for screen_contacted_housing_inspector question
RamiLorca
marked this pull request as ready for review
June 17, 2026 19:40
Collaborator
|
Noticing typo: condemned, not condemened. I'm also wondering if you think the warning is now TOO strong? Should we ask NLA for some more input on this? |
Collaborator
|
@RamiLorca please also ensure that the tests pass It's OK to leave warnings as-is, but please fix the new error you introduced: ERROR [EA509] docassemble/HousingCodeChecklist/data/questions/housing_code_interview.yml:3277 |
nonprofittechy
requested changes
Jun 17, 2026
Collaborator
|
Please remove use of and/or |
nonprofittechy
requested changes
Jun 20, 2026
…ded commonly used words that were triggering spellcheck to cSpell.words list in settings.json file
…n question block id: confirm notice
…n for add_inspection_letter; help text in get_inspection question; and condemn_warning screen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #654
get_inspectionquestion;condemn_warningscreen; and subquestion text aboveadd_inspection_letterquestion (see images below).Fixed #649
screen_contacted_housing_inspectoralready has a note that pops up with info on condemnation.tenant_called_inspector, which is identical to the question above.Fixed #648
Overall goal in edits below was to make language more accessible for the average user, while making the consequences of inspections and condemnations clearer. Also increasing number of places the user encounters reminders about condemnations.
Edited terms related to condemnation/displacement in
autoterms.yml.condemn_warningscreen and added collapse templates with explanatory text.screen_contacted_housing_inspectorquestion. Added another collapse template with info on condemnation.screen_contacted_housing_inspectorscreen.