Skip to content

Strengthened condemnation/displacement warnings - #661

Merged
nonprofittechy merged 7 commits into
mainfrom
648-warnings
Jun 26, 2026
Merged

Strengthened condemnation/displacement warnings#661
nonprofittechy merged 7 commits into
mainfrom
648-warnings

Conversation

@RamiLorca

@RamiLorca RamiLorca commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Fixed #654

  • Added language about receiving housing inspector contact info at the end of the interview to the following places: help text for get_inspection question; condemn_warning screen; and subquestion text above add_inspection_letter question (see images below).
Screenshot 2026-06-22 at 5 09 14 PM Screenshot 2026-06-22 at 5 07 48 PM Screenshot 2026-06-22 at 4 48 38 PM

Fixed #649

  • Question for variable screen_contacted_housing_inspector already has a note that pops up with info on condemnation.
  • I added the same note to the question for variable tenant_called_inspector, which is identical to the question above.

Fixed #648

  • Overall goal in edits below was to make language more accessible for the average user, while making the consequences of inspections and condemnations clearer. Also increasing number of places the user encounters reminders about condemnations.

  • Edited terms related to condemnation/displacement in autoterms.yml.

Screenshot 2026-06-12 at 5 19 27 PM Screenshot 2026-06-12 at 5 18 42 PM Screenshot 2026-06-12 at 5 18 52 PM Screenshot 2026-06-12 at 5 19 01 PM
  • Edited condemn_warningscreen and added collapse templates with explanatory text.
Screenshot 2026-06-12 at 5 17 28 PM Screenshot 2026-06-12 at 5 17 50 PM Screenshot 2026-06-12 at 5 39 42 PM
  • Edited note in screen_contacted_housing_inspector question. Added another collapse template with info on condemnation.
Screenshot 2026-06-12 at 3 02 35 PM
  • Added extra "question mark" help text link to "Get a city inspection" option in screen_contacted_housing_inspector screen.
Screenshot 2026-06-12 at 3 34 58 PM

…tes with help text; added help text with notice to get_inspection question; edited note for screen_contacted_housing_inspector question
@RamiLorca
RamiLorca marked this pull request as ready for review June 17, 2026 19:40
@nonprofittechy

Copy link
Copy Markdown
Collaborator

Noticing typo: condemned, not condemened.

I'm also wondering if you think the warning is now TOO strong? Should we ask NLA for some more input on this?

@nonprofittechy

nonprofittechy commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

@RamiLorca please also ensure that the tests pass

It's OK to leave warnings as-is, but please fix the new error you introduced:

ERROR [EA509] docassemble/HousingCodeChecklist/data/questions/housing_code_interview.yml:3277
link text in subquestion is too generic: here

@nonprofittechy nonprofittechy self-assigned this Jun 17, 2026

@nonprofittechy nonprofittechy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix misspellings and new accessibility finding; also make a new issue to check with NLA if the warnings are too strong now

@nonprofittechy

Copy link
Copy Markdown
Collaborator

Please remove use of and/or

@nonprofittechy nonprofittechy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread docassemble/HousingCodeChecklist/data/questions/autoterms.yml Outdated
Comment thread docassemble/HousingCodeChecklist/data/questions/housing_code_interview.yml Outdated
Comment thread docassemble/HousingCodeChecklist/data/questions/housing_code_interview.yml Outdated
…ded commonly used words that were triggering spellcheck to cSpell.words list in settings.json file
…n for add_inspection_letter; help text in get_inspection question; and condemn_warning screen
@RamiLorca
RamiLorca requested a review from nonprofittechy June 22, 2026 21:33
@nonprofittechy
nonprofittechy merged commit 6b7fa89 into main Jun 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants