Fix persistent GPS watchdog false clears - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Process.waitUntilExit()timeout race with a termination-handler based command runner that returns promptly and kills timed-out childrenopen()and retry lease acquisition on an explicit StartRoot cause
A timed-out
launchctlcheck stranded a synchronouswaitUntilExit()child inside a structured task group. The controller's only polling task never resumed, so both the heartbeat and UI status froze. Exactly five minutes later the worker treated the stale heartbeat as an app crash, sentclear, and stopped, while the stale UI still showed Belgrade as active.User impact
When Start remains selected and the GeoShift process is alive, the selected location now remains active even if UI monitoring is temporarily delayed. Restore GPS still clears explicitly, and a real process crash still hands cleanup to the worker.
Validation
flockbehavioractive, heartbeat advanced, and the installed GUI held the liveness lock