Repository navigation
[KS] Driver runs: pin TZ, mask architecture, follow-ups (#433) - #454
Merged
sethwebster merged 1 commit intoOct 13, 2026
Merged
Conversation
Launch the driven process with TZ=UTC so Date and Intl match the fixed timeZone; mask the architecture row in state-visual; document that a simulated powerChanged leaves batteryLevel null; assert the driver state exists before simulateSystemEvent writes it; fix a doc reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #433
Follow-up to #451.
What changed
state-visual.yaml: also maskssystem-integration-state-architecture, sincearm64shows at the golden's bottom edge.scripts/e2e/kitchen-sink.ts: the driven process now launches withTZ=UTC(PINNED_ENV, applied before the flow's ownenv, so a flow can still override it). JavaScript'sDate/IntlandNSTimeZonenow match the fixedtimeZone.tests/e2e-kitchen-sink-launch.test.tschecks the fake app receives it. Documented intest-driver.mdandsystem.md.powerChanged: rather than adding abatteryLevelfield,system.mdnow says thatonBatteryis simulated andbatteryLevelstaysnull.SparkSystemState.mm:NSCAssert(overrides)beforesimulateSystemEventwrites the driver state.RNWindowManager.mm: the comment now points todocs/displays.md#simulated-displays.Verification (run in this session)
bun run typecheck: pass.bun run e2e:lint: 0 problems.bun run test: 1981 passed, 3 failed:node-runtime(asdf shim) and themotion-nativeframes check (display asleep): the accepted host failures.media-nativeplayback timing (media.native.mm:174): passed when rerun on its own, and this PR doesn't touch media.system-integrationandinfra/catalog-driverwith--backend driverunderks-lock native: 41 passed, 0 failed, 4 skipped (Windows-only).TZ=UTCand the extra mask,system-integration-state(4 variants) andinfra-shell-catalogmatched with 0 different pixels. No golden was re-approved.