fix(mods): accept numeric Fantome versions - #321
Open
NoName-txt wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Fantome metadata expects
Versionto be a string, but some existing mods use a numeric value such as"Version": 1.1.This caused LTK Manager to reject the archive with:
A example is Sausage dog Naafiri, which could not be installed through the Install with LTK Manager flow.
This change:
ltk_fantome.How it was tested
"Version": 1.1format."Version": 2.cargo fmt --all -- --checkcargo clippy -- -D warningscargo test- 449 tests passed across 3 suites.Checklist
feat:/fix:/docs:/chore:;!for breaking)cargo fmt --all -- --checkpassescargo clippy -- -D warningspassescargo testpasses