fix(ltk_ritobin): don't panic on unterminated string values in build_bin - #169
Open
SAY-5 wants to merge 1 commit into
Open
fix(ltk_ritobin): don't panic on unterminated string values in build_bin#169SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
alanpq
requested changes
Aug 16, 2026
| }; | ||
| return resolve_literal(ctx, child.token(visit_ctx.cst).unwrap(), kind_hint); | ||
| // an unterminated string leaves an error tree here instead of a token | ||
| let Some(token) = child.token(visit_ctx.cst) else { |
Contributor
There was a problem hiding this comment.
Can you instead and_then this with the above child binding? We also don't need the comment, since there can be many reasons the next node isn't a token.
| let cst = Cst::parse(text); | ||
| assert!(!cst.errors.is_empty()); | ||
|
|
||
| // used to panic on the error tree left behind by the tokenizer |
| fn unterminated_string_value() { | ||
| let text = "name: string = \"\n"; | ||
| let cst = Cst::parse(text); | ||
| assert!(!cst.errors.is_empty()); |
Contributor
There was a problem hiding this comment.
Can you assert that the error list here is exactly the one error we expect?
| assert!(!cst.errors.is_empty()); | ||
|
|
||
| // used to panic on the error tree left behind by the tokenizer | ||
| let (_bin, _errors) = cst.build_bin(text); |
Contributor
There was a problem hiding this comment.
Should also assert that _errors is empty here (we rely on users of this crate to check for parse errors before assuming the resulting bin is valid, so there should be no typechecker-specific errors here)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #165
The Literal node holds an error tree instead of a token when the tokenizer hit an unterminated string, so
resolve_valuenow bails out with no value instead of unwrapping.