CI: sign Windows with ssign (drop the SimplySign container) - #14
Merged
Merged
Conversation
Replace the standalone SimplySign-Desktop-2.9.10 + PKCS#11 container workflow with a gated `sign-windows` job in ci.yml: the Linux runner installs ssign and Authenticode-signs pinready.exe via Certum (no Windows, no container). Gated by the `signing` environment (owner approval); `release` now needs it, so a tag is build → approve → signed release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0138mtPxwfXPetBypyjp6KwU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remplace le workflow expérimental
sign-windows.yml(conteneur SimplySign Desktop 2.9.10 + PKCS#11, ~143 lignes) par un jobsign-windowsgardé dansci.yml:ssign(crates.io) et signepinready.exevia Certum — sans Windows, sans conteneur, sans stack propriosigning(approbation propriétaire) ; le jobreleasele met enneeds:→ un tag devient build → approbation → release signéeosslsigncodeincluseÀ merger avant de builder la 0.17.2.
Note : les anciens secrets repo
CERTUM_USERID/CERTUM_TOTP_SECRET(pour le conteneur) deviennent inutiles → à supprimer.🤖 Generated with Claude Code