Skip to content

DEVREL-885 oft-solana: update node version - #1847

Merged
nazreen merged 9 commits into
mainfrom
bump-node-version-oft-solana
Dec 4, 2025
Merged

DEVREL-885 oft-solana: update node version#1847
nazreen merged 9 commits into
mainfrom
bump-node-version-oft-solana

Conversation

@nazreen

@nazreen nazreen commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

Problem

Running any of the hardhat scripts while on node v18 would lead to

Error HH19: Your project is an ESM project (you have "type": "module" set in your package.json) but your Hardhat config file uses the .js extension.

Change

  • examples/oft-solana: bump up node version from 18 to 20

Notes

EDIT: below is no longer relevant

When changing only the relevant node versions (.nvmrc, package.json engines..node) under examples/oft-solana, CI run failed: https://github.com/LayerZero-Labs/devtools/actions/runs/19719352708/job/56498667765?pr=1847

.../node_modules/utf-8-validate install: /bin/sh: 1: /github/home/setup-pnpm/node_modules/.pnpm/pnpm@8.15.6/node_modules/pnpm/dist/node_modules/node-gyp/gyp/gyp_main.py: Permission denied
...
.../node_modules/unrs-resolver postinstall: [napi-postinstall@0.3.4] Failed to find package "@unrs/resolver-binding-linux-arm64-gnu" on the file system
...
.../node_modules/utf-8-validate install: gyp ERR! build error 
.../node_modules/utf-8-validate install: gyp ERR! stack Error: `make` failed with exit code: 2
.../node_modules/utf-8-validate install: gyp ERR! stack     at ChildProcess.onExit (/github/home/setup-pnpm/node_modules/.pnpm/pnpm@8.15.6/node_modules/pnpm/dist/node_modules/node-gyp/lib/build.js:203:23)
.../node_modules/utf-8-validate install: gyp ERR! stack     at ChildProcess.emit (node:events:524:28)
.../node_modules/utf-8-validate install: gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:293:12)
.../node_modules/utf-8-validate install: gyp ERR! System Linux 6.14.0-1012-azure
.../node_modules/utf-8-validate install: gyp ERR! command "/usr/local/bin/node" "/github/home/setup-pnpm/node_modules/.pnpm/pnpm@8.15.6/node_modules/pnpm/dist/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
.../node_modules/utf-8-validate install: gyp ERR! cwd /__w/devtools/devtools/node_modules/.pnpm/utf-8-validate@5.0.10/node_modules/utf-8-validate
.../node_modules/utf-8-validate install: gyp ERR! node -v v20.19.5
.../node_modules/utf-8-validate install: gyp ERR! node-gyp -v v9.4.1
.../node_modules/utf-8-validate install: gyp ERR! not ok 
.../node_modules/bufferutil install: gyp info spawn make
.../node_modules/bufferutil install: gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
.../node_modules/bufferutil install: make: Entering directory '/__w/devtools/devtools/node_modules/.pnpm/bufferutil@4.0.8/node_modules/bufferutil/build'
.../node_modules/bufferutil install:   CC(target) Release/obj.target/bufferutil/src/bufferutil.o
.../node_modules/utf-8-validate install: Failed

The error results from node-gyp being located in a non-executable path, which prevents node-gyp from being executed during native rebuilds.

EDIT: after updating the base branch, the above CI error no longer occurs.

@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@nazreen
nazreen marked this pull request as ready for review November 27, 2025 13:06
@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@nazreen nazreen changed the title DEVREL-855 oft-solana: update node version DEVREL-885 oft-solana: update node version Nov 27, 2025
@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@nazreen

nazreen commented Nov 30, 2025

Copy link
Copy Markdown
Contributor Author

The base image was updated in #1854.

Tested in #1857 the changes in this PR WITHOUT doing the move of pnpm into an executable folder. Seemed to work fine. No more node-gyp related errors in CI.

@github-actions

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@nazreen
nazreen requested a review from rad-lz November 30, 2025 00:52
rad-lz
rad-lz previously approved these changes Dec 1, 2025

@St0rmBr3w St0rmBr3w left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a changeset

@St0rmBr3w St0rmBr3w changed the title DEVREL-885 oft-solana: update node version oft-solana: update node version Dec 1, 2025
@St0rmBr3w St0rmBr3w changed the title oft-solana: update node version DEVREL-885 oft-solana: update node version Dec 1, 2025
DanL0
DanL0 previously approved these changes Dec 2, 2025

@DanL0 DanL0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes a long standing issue, I am on node v20 locally for long time

@nazreen
nazreen dismissed stale reviews from DanL0 and rad-lz via 9ccf5e8 December 3, 2025 14:53
@github-actions

github-actions Bot commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

🚨 E2E Tests Failed

The E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:

This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information.

@nazreen
nazreen requested review from DanL0 and St0rmBr3w December 3, 2025 15:16
@nazreen
nazreen requested a review from rad-lz December 3, 2025 15:16
@nazreen

nazreen commented Dec 3, 2025

Copy link
Copy Markdown
Contributor Author

@St0rmBr3w changeset pushed

@nazreen
nazreen removed the request for review from St0rmBr3w December 4, 2025 00:43
@nazreen
nazreen dismissed St0rmBr3w’s stale review December 4, 2025 00:44

changeset has been pushed

@nazreen
nazreen merged commit 7dbac78 into main Dec 4, 2025
13 checks passed
@nazreen
nazreen deleted the bump-node-version-oft-solana branch December 4, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants