Calculated Column Expression Assistant#7665
Open
labkey-nicka wants to merge 19 commits into
Open
Conversation
This was referenced May 13, 2026
labkey-matthewb
approved these changes
May 13, 2026
Contributor
labkey-matthewb
left a comment
labkey-matthewb
left a comment
There was a problem hiding this comment.
I think we may need to give stronger guidance about injecting CAST(), as this generally will generate a runtime error rather than a parse error. Or we can try to generate execute a test SQL statement??? Not required for commit.
|
|
||
| HttpSession session = getViewContext().getRequest().getSession(true); | ||
| ChatClient chatSession = McpService.get().getChat(session, getAgentName(), this::getServicePrompt, create); | ||
| ChatClient chatSession = McpService.get().getChat(session, conversationName, this::getServicePrompt, create); |
Contributor
There was a problem hiding this comment.
Maybe rename the parameter name as well in McpService[Imp].getChat()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This introduces the calculated column expression assistant endpoint.
Related Pull Requests
Changes
conversationIdtoAbstractAgentActionto track conversation. Allows for clients to easily start and track conversation.ExpressionAssistantAgentActionthat is the endpoint for the expression assistantvalidateCalculatedColumnExpressionMCP tool that is used by expression assistant to validate expressions it creates@McpInternalannotation for MCP tools that are not intended for exposure to external servicesMcpContextto support supplying context beyond container and userLABKEY.mcpReadyflag to page context