Skip to content

chore(docs): drop WHATS_NEW_V2.{1,2}.md (CHANGELOG dupes) - #11

Merged
David Mireles (louzt) merged 1 commit into
mainfrom
chore/cleanup-2026-07-28
Jul 28, 2026
Merged

chore(docs): drop WHATS_NEW_V2.{1,2}.md (CHANGELOG dupes)#11
David Mireles (louzt) merged 1 commit into
mainfrom
chore/cleanup-2026-07-28

Conversation

@louzt

@louzt louzt commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Removes two release-specific docs files that duplicated information already present in the canonical CHANGELOG.md (Keep-a-Changelog format). Pure repo cleanup; zero behavior change.

Changes

  • delete docs/WHATS_NEW_V2.1.md (375 lines)
  • delete docs/WHATS_NEW_V2.2.md (576 lines)

Total: 2 files, 951 deletions.

Scope boundary (what this PR does NOT touch)

  • No code changes (Rust, Python, Svelte).
  • No binary rebuild (Windows installer stays at v3.1.0 source tag unless tagged separately).
  • No consolidation of windows/ vs platforms/python/ — that's a separate migration concern requiring its own branch and discussion.
  • No release-yet: this PR does NOT bump the project version or create a new release tag.

Validation evidence

$ git diff --stat main..HEAD
 docs/WHATS_NEW_V2.1.md | 375 --------------------------------
 docs/WHATS_NEW_V2.2.md | 576 -------------------------------------------------
 2 files changed, 951 deletions(-)

Why CHANGELOG.md is canonical

These WHATS_NEW_VN.M.md files were created during the v2.x development cycle to highlight release-specific features. The project subsequently adopted the Keep-a-Changelog format in CHANGELOG.md (## [2.1.0] - 2025-11-10, etc.) which makes the per-release summaries redundant. Removing the duplicates keeps a single source of truth.

Risk

Low. Removal of duplicate documentation files. No callers reference these in code or CI. git grep -l WHATS_NEW returns no matches in source code (only inside the files being deleted and a single historical reference inside CHANGELOG.md itself).

Audit context

See ~/Proyectos/OSS/_staging/MANIFEST-2026-07-28.md for full audit context.

🤖 Generated by LZT cleanup session 2026-07-28.

Summary by CodeRabbit

  • Bug Fixes

    • Improved DNS failover state handling by resetting failure counters when switching DNS providers.
    • Adjusted failover thresholds and cooldown timing to reduce unnecessary or overly frequent failovers.
  • Documentation

    • Removed outdated release notes for versions 2.1 and 2.2.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (2)
  • docs/WHATS_NEW_V2.1.md
  • docs/WHATS_NEW_V2.2.md
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e44ec690-b961-4fcc-b828-8404d73d618f

📥 Commits

Reviewing files that changed from the base of the PR and between 52f42ff and 4fc2742.

📒 Files selected for processing (2)
  • docs/WHATS_NEW_V2.1.md
  • docs/WHATS_NEW_V2.2.md

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

DNS failover defaults now use higher failure and cooldown thresholds. Failover execution resets consecutive failure counters for both DNS selections. The v2.1 and v2.2 release-notes documents were removed.

Changes

DNS failover behavior

Layer / File(s) Summary
Failover defaults and state reset
platforms/tauri/src-tauri/src/services/dns_intelligence.rs
Default failover thresholds and cooldown duration were increased, and failover now resets consecutive-failure counters for the previous and newly selected DNS servers.
Release notes removal
docs/WHATS_NEW_V2.1.md, docs/WHATS_NEW_V2.2.md
The v2.1 and v2.2 release-notes files were removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main docs cleanup by removing the duplicated WHATS_NEW release-note files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/cleanup-2026-07-28

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@platforms/tauri/src-tauri/src/services/dns_intelligence.rs`:
- Around line 685-696: The lock acquisition order in the update block must match
update_best_dns_static to prevent deadlocks. Acquire the metrics write lock
before the current_best write lock, while preserving the existing DNS assignment
and consecutive-failure resets.
- Around line 685-696: Move the state-update block associated with current_best
and metrics until after get_primary_adapter() and set_dns() both succeed. Only
on successful OS DNS application should you assign current_best, reset
consecutive_failures, and perform the related history and cooldown updates;
preserve the existing failure path without committing the new DNS state or
clearing failure evidence.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 50ba6d75-60d9-4653-a386-70578fe59aa8

📥 Commits

Reviewing files that changed from the base of the PR and between f7ebf54 and 52f42ff.

📒 Files selected for processing (3)
  • docs/WHATS_NEW_V2.1.md
  • docs/WHATS_NEW_V2.2.md
  • platforms/tauri/src-tauri/src/services/dns_intelligence.rs
💤 Files with no reviewable changes (2)
  • docs/WHATS_NEW_V2.1.md
  • docs/WHATS_NEW_V2.2.md

Comment thread platforms/tauri/src-tauri/src/services/dns_intelligence.rs Outdated
These release-specific docs duplicated the canonical Keep-a-Changelog format in CHANGELOG.md. Same info, two trees, no value. Future release notes stay in CHANGELOG.md only.

MANIFEST: ~/Proyectos/OSS/_staging/MANIFEST-2026-07-28.md
@louzt

louzt commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

CodeRabbit (@coderabbitai) review

Force-pushed after rebase onto origin/main. PR diff is now 2 files / 951 deletions only (docs cleanup). The prior threads on dns_intelligence.rs are stale (commit 7e8a957 was orphaned from this PR via rebase --onto). Please re-review the cleaned diff.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

@louzt I’ll re-review the current cleaned documentation-only diff for PR #11 and disregard the orphaned dns_intelligence.rs changes.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@louzt

louzt commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

CodeRabbit (@coderabbitai) approve

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
✅ Action performed

Comments resolved. Approval is disabled; enable reviews.request_changes_workflow to allow explicit top-level @coderabbitai resolve or @coderabbitai approve commands.

@louzt
David Mireles (louzt) merged commit 43accb8 into main Jul 28, 2026
3 checks passed
@louzt
David Mireles (louzt) deleted the chore/cleanup-2026-07-28 branch July 28, 2026 19:00
David Mireles (louzt) added a commit that referenced this pull request Jul 31, 2026
The CHANGELOG.md was last updated for v2.1.0 (2025-11-10) and missed
the entire v3.x release line. This commit backfills:

- v3.0.3 (2026-03-27) — Performance & Build Improvements
- v3.1.0 (2026-07-04) — NSIS bundler fix, netboozt-service removal,
  clippy cleanup
- v3.1.1 (2026-07-28) — docs-only PATCH (drop WHATS_NEW_V2 dupes;
  binary version inside installer remains 3.1.0 because Cargo.toml
  was not bumped for a docs-only commit)

Entries paraphrased from the corresponding GitHub Releases notes
to keep the Keep-a-Changelog format consistent with v2.x entries.

**Why:** CHANGELOG.md is the canonical project changelog per its
own header ("this project adheres to Semantic Versioning"). GitHub
Releases is a complementary surface, not a replacement.

**Refs:**
- #11 (drop WHATS_NEW_V2.{1,2}.md, the source of this gap)
- v3.1.1 release notes (the docs-only PATCH explanation)
- v3.0.3 / v3.1.0 release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant