chore(docs): drop WHATS_NEW_V2.{1,2}.md (CHANGELOG dupes) - #11
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (2)
⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughDNS failover defaults now use higher failure and cooldown thresholds. Failover execution resets consecutive failure counters for both DNS selections. The v2.1 and v2.2 release-notes documents were removed. ChangesDNS failover behavior
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@platforms/tauri/src-tauri/src/services/dns_intelligence.rs`:
- Around line 685-696: The lock acquisition order in the update block must match
update_best_dns_static to prevent deadlocks. Acquire the metrics write lock
before the current_best write lock, while preserving the existing DNS assignment
and consecutive-failure resets.
- Around line 685-696: Move the state-update block associated with current_best
and metrics until after get_primary_adapter() and set_dns() both succeed. Only
on successful OS DNS application should you assign current_best, reset
consecutive_failures, and perform the related history and cooldown updates;
preserve the existing failure path without committing the new DNS state or
clearing failure evidence.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 50ba6d75-60d9-4653-a386-70578fe59aa8
📒 Files selected for processing (3)
docs/WHATS_NEW_V2.1.mddocs/WHATS_NEW_V2.2.mdplatforms/tauri/src-tauri/src/services/dns_intelligence.rs
💤 Files with no reviewable changes (2)
- docs/WHATS_NEW_V2.1.md
- docs/WHATS_NEW_V2.2.md
These release-specific docs duplicated the canonical Keep-a-Changelog format in CHANGELOG.md. Same info, two trees, no value. Future release notes stay in CHANGELOG.md only. MANIFEST: ~/Proyectos/OSS/_staging/MANIFEST-2026-07-28.md
52f42ff to
4fc2742
Compare
|
CodeRabbit (@coderabbitai) review Force-pushed after rebase onto origin/main. PR diff is now 2 files / 951 deletions only (docs cleanup). The prior threads on dns_intelligence.rs are stale (commit 7e8a957 was orphaned from this PR via rebase --onto). Please re-review the cleaned diff. |
|
✅ Action performedReview finished.
|
|
CodeRabbit (@coderabbitai) approve |
✅ Action performedComments resolved. Approval is disabled; enable |
The CHANGELOG.md was last updated for v2.1.0 (2025-11-10) and missed
the entire v3.x release line. This commit backfills:
- v3.0.3 (2026-03-27) — Performance & Build Improvements
- v3.1.0 (2026-07-04) — NSIS bundler fix, netboozt-service removal,
clippy cleanup
- v3.1.1 (2026-07-28) — docs-only PATCH (drop WHATS_NEW_V2 dupes;
binary version inside installer remains 3.1.0 because Cargo.toml
was not bumped for a docs-only commit)
Entries paraphrased from the corresponding GitHub Releases notes
to keep the Keep-a-Changelog format consistent with v2.x entries.
**Why:** CHANGELOG.md is the canonical project changelog per its
own header ("this project adheres to Semantic Versioning"). GitHub
Releases is a complementary surface, not a replacement.
**Refs:**
- #11 (drop WHATS_NEW_V2.{1,2}.md, the source of this gap)
- v3.1.1 release notes (the docs-only PATCH explanation)
- v3.0.3 / v3.1.0 release notes
Summary
Removes two release-specific docs files that duplicated information already present in the canonical
CHANGELOG.md(Keep-a-Changelog format). Pure repo cleanup; zero behavior change.Changes
docs/WHATS_NEW_V2.1.md(375 lines)docs/WHATS_NEW_V2.2.md(576 lines)Total: 2 files, 951 deletions.
Scope boundary (what this PR does NOT touch)
windows/vsplatforms/python/— that's a separate migration concern requiring its own branch and discussion.Validation evidence
Why CHANGELOG.md is canonical
These
WHATS_NEW_VN.M.mdfiles were created during the v2.x development cycle to highlight release-specific features. The project subsequently adopted the Keep-a-Changelog format inCHANGELOG.md(## [2.1.0] - 2025-11-10, etc.) which makes the per-release summaries redundant. Removing the duplicates keeps a single source of truth.Risk
Low. Removal of duplicate documentation files. No callers reference these in code or CI.
git grep -l WHATS_NEWreturns no matches in source code (only inside the files being deleted and a single historical reference insideCHANGELOG.mditself).Audit context
See
~/Proyectos/OSS/_staging/MANIFEST-2026-07-28.mdfor full audit context.🤖 Generated by LZT cleanup session 2026-07-28.
Summary by CodeRabbit
Bug Fixes
Documentation