Repository navigation
chore(patches): draw the Dev Menu header icon like the home screen - #72
Merged
Merged
Conversation
…reen The Dev Menu header draws the app icon differently from the launcher, which mangles the app-icon-badge banner and ribbon on dev/preview builds. On iOS `HeaderView.swift` clips a 38pt box with a 16pt radius, nearly a circle, so the badge edges are cut off; the patch uses 8.5pt continuous (the ~22% iOS icon ratio). On Android `AppIcon.kt` stacks the adaptive icon's background and foreground layers without the launcher mask or the 72/108 crop, so the whole 108dp canvas shows and the badge sits in the wrong place; the patch lets `AdaptiveIconDrawable` draw itself, which applies both. `patches/README.md` states when to drop it. Dev only. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Shaking open the Dev Menu showed the app-icon-badge banner and ribbon mangled while the home-screen icon was fine. The image is the same file (pixel diff 0 against the asset catalog); the dev menu renders it differently.
What
patches/expo-dev-menu@57.0.18.patchHeaderView.swift: the 38pt box was clipped withcornerRadius: 16(42% of the side, nearly a circle) →8.5, style: .continuous(~22%, the iOS icon ratio). The bottom banner and corner ribbon are no longer cut off.AppIcon.kt: stacked the adaptive icon's layers in aLayerDrawablewithout the launcher mask or the 72/108 crop, so the full 108dp canvas showed and the badge landed in the wrong place → letAdaptiveIconDrawabledraw itself (toBitmap→drawapplies both).Registered in
pnpm-workspace.yaml; history and removal condition inpatches/README.md; CHANGELOG under Unreleased. Dev only.Verified
:expo-dev-menu:compileDebugKotlinBUILD SUCCESSFUL (no warnings from the patched file)expo-dev-menupod target BUILD SUCCEEDED (HeaderView.swiftcompiles clean)Note: the full iOS app build currently fails in
@expo/ui(NavigationSplitViewViewnot in scope) becauseios/Podsdates from Sep 17 and@expo/uimoved to 57.0.19 since. Unrelated to this PR;pod install(orexpo run:ios) fixes it.🤖 Generated with Claude Code