Repository navigation
feat: Generalise the alert system and add directional arrow support via the @left and @right syntax
#3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: Generalise the alert system and add directional arrow support via the @left and @right syntax
#3
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
27d4083
feat: generalise the alert system away from just bugs
cooperj 236acd3
chore: rm old bugs
cooperj 3f35b9a
feat: add directional alert UI and theme-driven audio
cooperj 8415156
Potential fix for pull request finding
cooperj 9961fb3
feat: update alert system to use configurable alert persistence and a…
cooperj b11584e
fix: undo copilot suggestion that makes error alerts play twice
cooperj e55fa18
fix: make it so on alerts with multiple detections the direction is s…
cooperj 6990c13
chore: bump version from v0.0.0 to v1.0.0
cooperj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct. I will be getting in alerts for
diseased_plantand notjute. However, the ROS system underpinning this will have the detections correctly.