Repository navigation
fix(metaaggregation): restore compatibility with updated aggregator-encoding - #231
Merged
Merged
Conversation
thanhpp
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading a consumer to aggregator-encoding v0.73.96 breaks compilation of
pkg/metaaggregation: its V2 input types and packing helpers have moved fromencode/v3/routertoencode/v2/router.Update the production and test imports to the V2 package and upgrade aggregator-encoding from v0.73.8 to v0.73.96. The old pinned version does not contain the new package.
go mod tidyupdates the required dependency graph and Go minimum to 1.25.10.DecodeMetaAggregationSwapOutputand the V2 calldata/output format remain unchanged. Add regression coverage for valid V2 output, zero gas, and truncated output; existing calldata fixtures continue to pass. This lets the resolver retain its existing metaaggregation decoder after the ks-enc upgrade.Validation:
go test -race ./...passes.golangci-lint run --new-from-rev=main ./pkg/metaaggregation/...passes. The unrestricted scoped lint reports an existingmodernizewarning for[2]interface{}in the unchanged decoder.Follow-up consumer: https://github.com/KyberNetwork/1inch-resolver/pull/700