Skip to content

fix(metaaggregation): restore compatibility with updated aggregator-encoding - #231

Merged
vaigay merged 1 commit into
mainfrom
codex/fix-metaaggregation-router-import
Sep 23, 2026
Merged

vaigay merged 1 commit into
mainfrom
codex/fix-metaaggregation-router-import

Conversation

@vaigay

@vaigay vaigay commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Upgrading a consumer to aggregator-encoding v0.73.96 breaks compilation of pkg/metaaggregation: its V2 input types and packing helpers have moved from encode/v3/router to encode/v2/router.

Update the production and test imports to the V2 package and upgrade aggregator-encoding from v0.73.8 to v0.73.96. The old pinned version does not contain the new package. go mod tidy updates the required dependency graph and Go minimum to 1.25.10.

DecodeMetaAggregationSwapOutput and the V2 calldata/output format remain unchanged. Add regression coverage for valid V2 output, zero gas, and truncated output; existing calldata fixtures continue to pass. This lets the resolver retain its existing metaaggregation decoder after the ks-enc upgrade.

Validation:

  • go test -race ./... passes.
  • golangci-lint run --new-from-rev=main ./pkg/metaaggregation/... passes. The unrestricted scoped lint reports an existing modernize warning for [2]interface{} in the unchanged decoder.
  • Resolver ETHPAMM, findroute, kyberswap, service, resolver, and cmd/app tests/build pass using a temporary module-file replacement pointing to this checkout.

Follow-up consumer: https://github.com/KyberNetwork/1inch-resolver/pull/700

@vaigay
vaigay merged commit c7b3fbd into main Sep 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants